mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: zihan zhou <15645113830zzh@gmail.com>,
	mingo@redhat.com, juri.lelli@redhat.com,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	linux-kernel@vger.kernel.org, zhouzihan30@jd.com,
	yaozhenguo <yaozhenguo@jd.com>, yaowenchao1 <yaowenchao@jd.com>
Subject: Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug
Date: Fri, 17 Jan 2025 12:38:13 +0100	[thread overview]
Message-ID: <20250117113813.GA8603@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtBxCsyYJjh99vpj+zCtQyPbbHjdo=ucaiL6Nbb08Af3uQ@mail.gmail.com>

On Fri, Jan 17, 2025 at 09:32:43AM +0100, Vincent Guittot wrote:
> On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@gmail.com> wrote:
> >
> > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> > tasks" table, but not all tasks in the table are runnable.
> > It is inappropriate to refer to this table as "runnable tasks", so here it
> > is changed to "Tasks on CPU %d", like:
> 
> We have used replaced runnable by queued in fair scheduler

Right, but also 'tasks on cpu' is equally wrong -- but really, if you're
looking at sched/debug you have to know what you're doing anyway, so why
bother with trivial stuff like this?

> > Tasks on cpu 31:
> >  S            task   PID       vruntime   eligible    deadline
> > --------------------------------------------------------------------
> >  S        cpuhp/31   173         0.803286   E           2.153245
> >  S    migration/31   174         8.167468   E          11.167468
> >
> > PS For the sake of clarity in reality, some table information has been
> > omitted here.
> >
> >
> > Signed-off-by: zihan zhou <15645113830zzh@gmail.com>
> > Signed-off-by: yaozhenguo <yaozhenguo@jd.com>
> > Signed-off-by: yaowenchao1 <yaowenchao@jd.com>

And that's a broken SoB chain.

  reply	other threads:[~2025-01-17 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  2:22 zihan zhou
2025-01-17  8:32 ` Vincent Guittot
2025-01-17 11:38   ` Peter Zijlstra [this message]
2025-01-20  7:44     ` [PATCH V2] sched: Forward deadline for early tick zihan zhou
2025-01-20  7:55       ` zihan zhou
2025-01-20  7:49     ` [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug zihan zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117113813.GA8603@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=15645113830zzh@gmail.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yaowenchao@jd.com \
    --cc=yaozhenguo@jd.com \
    --cc=zhouzihan30@jd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®