mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Alice Ryhl <aliceryhl@google.com>
Subject: Re: [GIT PULL] tracing: Updates for v6.14
Date: Mon, 20 Jan 2025 12:45:24 -0500	[thread overview]
Message-ID: <20250120124524.2ed6fdf7@gandalf.local.home> (raw)
In-Reply-To: <20250119192902.576eda90@gandalf.local.home>

On Sun, 19 Jan 2025 19:29:02 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> - Add :mod: command to enable events for current or future modules
> 
>   The function tracer already has a way to enable functions to be traced in
>   modules by writing ":mod:<module>" into set_ftrace_filter. That will
>   enable either all the functions for the module if it is loaded, or if it
>   is not, it will cache that command, and when the module is loaded that
>   matches <module>, its functions will be enabled. This also allows init
>   functions to be traced. But currently events do not have that feature.
> 
>   Add the command where if ':mod:<module>' is written into set_event, then
>   either all the modules events are enabled if it is loaded, or cache it so
>   that the module's events are enabled when it is loaded. This also works
>   from the kernel command line, where "trace_event=:mod:<module>", when the
>   module is loaded at boot up, its events will be enabled then.

This change added a "#if CONFIG_MODULES" when it should have been a
"#ifdef CONFIG_MODULES". The kernel robot reported this over a week ago and
I fixed it locally, but got distracted and never sent out the fix nor
tested nor applied it.

I'm doing that now, so you can hold off on this pull request.

Thanks,

-- Steve

  reply	other threads:[~2025-01-20 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20  0:29 Steven Rostedt
2025-01-20 17:45 ` Steven Rostedt [this message]
2025-01-21 23:20   ` Linus Torvalds
2025-01-21 23:28     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120124524.2ed6fdf7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=aliceryhl@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®