From: Louis Chauvet <louis.chauvet@bootlin.com>
To: "Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"Maíra Canal" <mairacanal@riseup.net>,
"Haneen Mohammed" <hamohammed.sa@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Simona Vetter" <simona.vetter@ffwll.ch>
Cc: jose.exposito89@gmail.com, dri-devel@lists.freedesktop.org,
arthurgrillo@riseup.net, linux-kernel@vger.kernel.org,
jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com,
thomas.petazzoni@bootlin.com, seanpaul@google.com,
nicolejadeyee@google.com,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH RFC v3 02/14] drm/vkms: Cleanup configuration field on device destroy
Date: Tue, 21 Jan 2025 15:34:46 +0100 [thread overview]
Message-ID: <20250121-google-config-fs-v3-2-8154a6945142@bootlin.com> (raw)
In-Reply-To: <20250121-google-config-fs-v3-0-8154a6945142@bootlin.com>
To avoid having dangling pointers in struct vkms_config, remove all of
them when the device is destroyed.
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
drivers/gpu/drm/vkms/vkms_config.c | 23 +++++++++++++++++++++++
drivers/gpu/drm/vkms/vkms_config.h | 3 ++-
drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
index a20644031ce923fad98d486a8bb2ec7859038dcd..8ac9cd52cc00f7c317f2514a73c3d2f3908b085b 100644
--- a/drivers/gpu/drm/vkms/vkms_config.c
+++ b/drivers/gpu/drm/vkms/vkms_config.c
@@ -167,6 +167,29 @@ struct vkms_config_connector *vkms_config_create_connector(struct vkms_config *v
return vkms_config_connector;
}
+void vkms_config_disconnect_dev(struct vkms_config *vkms_config)
+{
+ struct vkms_config_connector *connector, *tmp_connector;
+ struct vkms_config_encoder *encoder, *tmp_encoder;
+ struct vkms_config_plane *plane, *tmp_plane;
+ struct vkms_config_crtc *crtc, *tmp_crtc;
+
+ vkms_config->dev = NULL;
+
+ list_for_each_entry_safe(connector, tmp_connector, &vkms_config->connectors, link) {
+ connector->connector = NULL;
+ }
+ list_for_each_entry_safe(encoder, tmp_encoder, &vkms_config->encoders, link) {
+ encoder->encoder = NULL;
+ }
+ list_for_each_entry_safe(plane, tmp_plane, &vkms_config->planes, link) {
+ plane->plane = NULL;
+ }
+ list_for_each_entry_safe(crtc, tmp_crtc, &vkms_config->crtcs, link) {
+ crtc->output = NULL;
+ }
+}
+
void vkms_config_connector_update_status(struct vkms_config_connector *vkms_config_connector,
enum drm_connector_status status)
{
diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms_config.h
index 23f420291cfc0044ccb2be90688d021aab10c1c0..2e5d2aa34a4f039c738cb9ac5642f3c75df36ba7 100644
--- a/drivers/gpu/drm/vkms/vkms_config.h
+++ b/drivers/gpu/drm/vkms/vkms_config.h
@@ -109,10 +109,11 @@ struct vkms_config_connector {
char edid_blob[PAGE_SIZE];
int edid_blob_len;
- /* Internal usage */
+ /* Set only when the device is enabled */
struct drm_connector *connector;
};
+void vkms_config_disconnect_dev(struct vkms_config *vkms_config);
void vkms_config_connector_update_status(struct vkms_config_connector *vkms_config_connector,
enum drm_connector_status status);
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 5f1958d59cc4c3102352599eee7a8e139fbb899c..afbd1fbe00d469bea8367096a3aa0ed07b66ed1a 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -240,7 +240,7 @@ void vkms_destroy(struct vkms_config *config)
devres_release_group(&pdev->dev, NULL);
platform_device_unregister(pdev);
- config->dev = NULL;
+ vkms_config_disconnect_dev(config);
}
static void __exit vkms_exit(void)
--
2.47.1
next prev parent reply other threads:[~2025-01-21 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 14:34 [PATCH RFC v3 00/14] drm/vkms: ConfigFS interface Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 01/14] drm/vkms: Add vkms_delete/create_device helper Louis Chauvet
2025-01-21 14:34 ` Louis Chauvet [this message]
2025-01-21 14:34 ` [PATCH RFC v3 03/14] drm/vkms: Introduce ConfigFS interface Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 04/14] drm/vkms: Introduce configfs for plane Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 05/14] drm/vkms: Introduce configfs for plane rotation Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 06/14] drm/vkms: Introduce configfs for crtc and encoder Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 07/14] drm/vkms: Introduce configfs for connectors Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 08/14] drm/vkms: Introduce configfs for connector type Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 09/14] drm/vkms: Introduce configfs for plane format Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 10/14] drm/vkms: Introduce configfs for device name Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 11/14] drm/vkms: Introduce configfs for connector status Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 12/14] drm/vkms: Introduce configfs for connector id Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 13/14] drm/vkms: Introduce configfs for connector EDID Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 14/14] drm/vkms: Introduce configfs for encoder type Louis Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121-google-config-fs-v3-2-8154a6945142@bootlin.com \
--to=louis.chauvet@bootlin.com \
--cc=airlied@gmail.com \
--cc=arthurgrillo@riseup.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=jeremie.dautheribes@bootlin.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=nicolejadeyee@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=seanpaul@google.com \
--cc=simona.vetter@ffwll.ch \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®