From: Louis Chauvet <louis.chauvet@bootlin.com>
To: "Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"Maíra Canal" <mairacanal@riseup.net>,
"Haneen Mohammed" <hamohammed.sa@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Simona Vetter" <simona.vetter@ffwll.ch>
Cc: jose.exposito89@gmail.com, dri-devel@lists.freedesktop.org,
arthurgrillo@riseup.net, linux-kernel@vger.kernel.org,
jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com,
thomas.petazzoni@bootlin.com, seanpaul@google.com,
nicolejadeyee@google.com,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH RFC v3 08/14] drm/vkms: Introduce configfs for connector type
Date: Tue, 21 Jan 2025 15:34:52 +0100 [thread overview]
Message-ID: <20250121-google-config-fs-v3-8-8154a6945142@bootlin.com> (raw)
In-Reply-To: <20250121-google-config-fs-v3-0-8154a6945142@bootlin.com>
To allows the userspace to test many hardware configuration, introduce a
new interface to change a connector type.
The type of a connector can be changed by editing the file type and by
writing the connector type number.
The current interface is:
/config/vkms
DEVICE_1
┣━ enable
┣━ planes
┃ ┗━ [...]
┣━ connectors
┃ ┗━ CONNECTOR_1
┃ ┣━ possible_encoders
┃ ┗━ type
┗━ encoders
┗━ [...]
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
drivers/gpu/drm/vkms/vkms_configfs.c | 71 ++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
index 8bb3223c810dddb7d713ad4b01cece825f9939f6..5f416260f209fc98939f8addd175e5c3b8e35353 100644
--- a/drivers/gpu/drm/vkms/vkms_configfs.c
+++ b/drivers/gpu/drm/vkms/vkms_configfs.c
@@ -633,12 +633,83 @@ static void connector_release(struct config_item *item)
kfree(vkms_configfs_connector);
}
+static ssize_t connector_type_show(struct config_item *item, char *page)
+{
+ struct vkms_config_connector *connector;
+ int connector_type;
+ struct vkms_configfs_device *vkms_configfs = connector_child_item_to_vkms_configfs_device(item);
+
+ mutex_lock(&vkms_configfs->lock);
+ connector = connector_item_to_vkms_configfs_connector(item)->vkms_config_connector;
+ connector_type = connector->type;
+ mutex_unlock(&vkms_configfs->lock);
+
+ return sprintf(page, "%u", connector_type);
+}
+
+static ssize_t connector_type_store(struct config_item *item,
+ const char *page, size_t count)
+{
+ struct vkms_config_connector *connector;
+ int val = DRM_MODE_CONNECTOR_VIRTUAL;
+ struct vkms_configfs_device *vkms_configfs = connector_child_item_to_vkms_configfs_device(item);
+ int ret;
+
+ ret = kstrtouint(page, 10, &val);
+ if (ret)
+ return ret;
+
+ switch (val) {
+ case DRM_MODE_CONNECTOR_Unknown:
+ case DRM_MODE_CONNECTOR_VGA:
+ case DRM_MODE_CONNECTOR_DVII:
+ case DRM_MODE_CONNECTOR_DVID:
+ case DRM_MODE_CONNECTOR_DVIA:
+ case DRM_MODE_CONNECTOR_Composite:
+ case DRM_MODE_CONNECTOR_SVIDEO:
+ case DRM_MODE_CONNECTOR_LVDS:
+ case DRM_MODE_CONNECTOR_Component:
+ case DRM_MODE_CONNECTOR_9PinDIN:
+ case DRM_MODE_CONNECTOR_DisplayPort:
+ case DRM_MODE_CONNECTOR_HDMIA:
+ case DRM_MODE_CONNECTOR_HDMIB:
+ case DRM_MODE_CONNECTOR_TV:
+ case DRM_MODE_CONNECTOR_eDP:
+ case DRM_MODE_CONNECTOR_VIRTUAL:
+ case DRM_MODE_CONNECTOR_DSI:
+ case DRM_MODE_CONNECTOR_DPI:
+ case DRM_MODE_CONNECTOR_SPI:
+ case DRM_MODE_CONNECTOR_USB:
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ scoped_guard(mutex, &vkms_configfs->lock) {
+ if (vkms_configfs->enabled)
+ return -EINVAL;
+
+ connector = connector_item_to_vkms_configfs_connector(item)->vkms_config_connector;
+ connector->type = val;
+ }
+
+ return count;
+}
+
+CONFIGFS_ATTR(connector_, type);
+
+static struct configfs_attribute *connector_attrs[] = {
+ &connector_attr_type,
+ NULL,
+};
+
static struct configfs_item_operations connector_item_operations = {
.release = connector_release,
};
static const struct config_item_type connector_item_type = {
.ct_item_ops = &connector_item_operations,
+ .ct_attrs = connector_attrs,
.ct_owner = THIS_MODULE,
};
--
2.47.1
next prev parent reply other threads:[~2025-01-21 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 14:34 [PATCH RFC v3 00/14] drm/vkms: ConfigFS interface Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 01/14] drm/vkms: Add vkms_delete/create_device helper Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 02/14] drm/vkms: Cleanup configuration field on device destroy Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 03/14] drm/vkms: Introduce ConfigFS interface Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 04/14] drm/vkms: Introduce configfs for plane Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 05/14] drm/vkms: Introduce configfs for plane rotation Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 06/14] drm/vkms: Introduce configfs for crtc and encoder Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 07/14] drm/vkms: Introduce configfs for connectors Louis Chauvet
2025-01-21 14:34 ` Louis Chauvet [this message]
2025-01-21 14:34 ` [PATCH RFC v3 09/14] drm/vkms: Introduce configfs for plane format Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 10/14] drm/vkms: Introduce configfs for device name Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 11/14] drm/vkms: Introduce configfs for connector status Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 12/14] drm/vkms: Introduce configfs for connector id Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 13/14] drm/vkms: Introduce configfs for connector EDID Louis Chauvet
2025-01-21 14:34 ` [PATCH RFC v3 14/14] drm/vkms: Introduce configfs for encoder type Louis Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121-google-config-fs-v3-8-8154a6945142@bootlin.com \
--to=louis.chauvet@bootlin.com \
--cc=airlied@gmail.com \
--cc=arthurgrillo@riseup.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=jeremie.dautheribes@bootlin.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=nicolejadeyee@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=seanpaul@google.com \
--cc=simona.vetter@ffwll.ch \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®