From: Beata Michalska <beata.michalska@arm.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org,
catalin.marinas@arm.com, rafael@kernel.org,
viresh.kumar@linaro.org
Cc: sumitg@nvidia.com, yang@os.amperecomputing.com,
vanshikonda@os.amperecomputing.com, lihuisong@huawei.com,
zhanjie9@hisilicon.com
Subject: [PATCH v9 5/5] arm64: Update AMU-based freq scale factor on entering idle
Date: Tue, 21 Jan 2025 08:44:35 +0000 [thread overview]
Message-ID: <20250121084435.2839280-6-beata.michalska@arm.com> (raw)
In-Reply-To: <20250121084435.2839280-1-beata.michalska@arm.com>
Now that the frequency scale factor has been activated for retrieving
current frequency on a given CPU, trigger its update upon entering
idle. This will, to an extent, allow querying last known frequency
in a non-invasive way. It will also improve the frequency scale factor
accuracy when a CPU entering idle did not receive a tick for a while.
As a consequence, for idle cores, the reported frequency will be the
last one observed before entering the idle state.
Suggested-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Signed-off-by: Beata Michalska <beata.michalska@arm.com>
---
arch/arm64/kernel/topology.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 5f5738b174c7..6c43aafac77c 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -213,6 +213,19 @@ static __always_inline bool amu_fie_cpu_supported(unsigned int cpu)
cpumask_test_cpu(cpu, amu_fie_cpus);
}
+void arch_cpu_idle_enter(void)
+{
+ unsigned int cpu = smp_processor_id();
+
+ if (!amu_fie_cpu_supported(cpu))
+ return;
+
+ /* Kick in AMU update but only if one has not happened already */
+ if (housekeeping_cpu(cpu, HK_TYPE_TICK) &&
+ time_is_before_jiffies(per_cpu(cpu_amu_samples.last_scale_update, cpu)))
+ amu_scale_freq_tick();
+}
+
#define AMU_SAMPLE_EXP_MS 20
int arch_freq_get_on_cpu(int cpu)
--
2.25.1
next prev parent reply other threads:[~2025-01-21 8:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 8:44 [PATCH v9 0/5] Add support for AArch64 AMUv1-based average freq Beata Michalska
2025-01-21 8:44 ` [PATCH v9 1/5] cpufreq: Allow arch_freq_get_on_cpu to return an error Beata Michalska
2025-01-21 10:47 ` Viresh Kumar
2025-01-21 15:14 ` Beata Michalska
2025-01-21 18:40 ` Vanshidhar Konda
2025-01-23 21:37 ` Beata Michalska
2025-01-22 6:12 ` Viresh Kumar
2025-01-23 21:45 ` Beata Michalska
2025-01-24 3:33 ` Viresh Kumar
2025-01-28 8:09 ` Beata Michalska
2025-01-28 8:18 ` Viresh Kumar
2025-01-21 10:47 ` Prasanna Kumar T S M
2025-01-24 4:15 ` Prasanna Kumar T S M
2025-01-21 8:44 ` [PATCH v9 2/5] cpufreq: Introduce an optional cpuinfo_avg_freq sysfs entry Beata Michalska
2025-01-21 10:53 ` Viresh Kumar
2025-01-21 15:17 ` Beata Michalska
2025-01-22 6:09 ` Viresh Kumar
2025-01-23 21:47 ` Beata Michalska
2025-01-24 3:27 ` Viresh Kumar
2025-01-28 8:43 ` Prasanna Kumar T S M
2025-01-29 11:29 ` Sumit Gupta
2025-01-21 8:44 ` [PATCH v9 3/5] arm64: amu: Delay allocating cpumask for AMU FIE support Beata Michalska
2025-01-24 4:48 ` Prasanna Kumar T S M
2025-01-29 11:17 ` Sumit Gupta
2025-01-21 8:44 ` [PATCH v9 4/5] arm64: Provide an AMU-based version of arch_freq_get_on_cpu Beata Michalska
2025-01-24 4:43 ` Prasanna Kumar T S M
2025-01-28 8:16 ` Beata Michalska
2025-01-28 8:52 ` Prasanna Kumar T S M
2025-01-29 11:15 ` Sumit Gupta
2025-01-21 8:44 ` Beata Michalska [this message]
2025-01-24 4:45 ` [PATCH v9 5/5] arm64: Update AMU-based freq scale factor on entering idle Prasanna Kumar T S M
2025-01-29 11:13 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121084435.2839280-6-beata.michalska@arm.com \
--to=beata.michalska@arm.com \
--cc=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=lihuisong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=sumitg@nvidia.com \
--cc=vanshikonda@os.amperecomputing.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®