* [PATCH] hwmom/applesmc: add imacpro
@ 2025-01-21 12:31 Atharva Tiwari
2025-01-23 4:14 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Atharva Tiwari @ 2025-01-21 12:31 UTC (permalink / raw)
Cc: evepolonium, Henrik Rydberg, Jean Delvare, Guenter Roeck,
linux-hwmon, linux-kernel
this patch adds the iMacPro to the whitelist
as one iMacPro has been released (iMacPro 1,1)
thanks
Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
drivers/hwmon/applesmc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
index 7964b0e0c5e8..20e390d595e0 100644
--- a/drivers/hwmon/applesmc.c
+++ b/drivers/hwmon/applesmc.c
@@ -1373,6 +1373,10 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = {
DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
DMI_MATCH(DMI_PRODUCT_NAME, "iMac") },
},
+ { applesmc_dmi_match, "Apple iMacPro", {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "iMacPro") },
+ },
{ applesmc_dmi_match, "Apple Xserve", {
DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
DMI_MATCH(DMI_PRODUCT_NAME, "Xserve") },
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmom/applesmc: add imacpro
2025-01-21 12:31 [PATCH] hwmom/applesmc: add imacpro Atharva Tiwari
@ 2025-01-23 4:14 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-01-23 4:14 UTC (permalink / raw)
To: Atharva Tiwari; +Cc: Henrik Rydberg, Jean Delvare, linux-hwmon, linux-kernel
On 1/21/25 04:31, Atharva Tiwari wrote:
> this patch adds the iMacPro to the whitelist
> as one iMacPro has been released (iMacPro 1,1)
>
> thanks
>
From Documentation/process/submitting-patches.rst:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
"
Also, "thanks" is not part of a patch description. For details on how
to write a patch description please see "Describe your changes" in above
referenced document.
Guenter
> Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
> ---
> drivers/hwmon/applesmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 7964b0e0c5e8..20e390d595e0 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -1373,6 +1373,10 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = {
> DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME, "iMac") },
> },
> + { applesmc_dmi_match, "Apple iMacPro", {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "iMacPro") },
> + },
> { applesmc_dmi_match, "Apple Xserve", {
> DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Xserve") },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-23 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-21 12:31 [PATCH] hwmom/applesmc: add imacpro Atharva Tiwari
2025-01-23 4:14 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®