* [PATCH v2] iio: adc: ad7192: fix channel select
@ 2025-01-24 15:07 Markus Burri
2025-01-25 12:22 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Markus Burri @ 2025-01-24 15:07 UTC (permalink / raw)
To: linux-kernel
Cc: Markus Burri, Lars-Peter Clausen, Michael Hennerich,
Alisa-Dariana Roman, Jonathan Cameron, linux-iio, Nuno Sá
Channel configuration doesn't work as expected.
For FIELD_PREP the bit mask is needed and not the bit number.
Fixes: 874bbd1219c7 ("iio: adc: ad7192: Use bitfield access macros")
Signed-off-by: Markus Burri <markus.burri@mt.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index 1c87db0e0460..c4effe8429c8 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon
conf &= ~AD7192_CONF_CHAN_MASK;
for_each_set_bit(i, scan_mask, 8)
- conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i);
+ conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i));
ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf);
if (ret < 0)
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] iio: adc: ad7192: fix channel select
2025-01-24 15:07 [PATCH v2] iio: adc: ad7192: fix channel select Markus Burri
@ 2025-01-25 12:22 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2025-01-25 12:22 UTC (permalink / raw)
To: Markus Burri
Cc: linux-kernel, Lars-Peter Clausen, Michael Hennerich,
Alisa-Dariana Roman, linux-iio, Nuno Sá
On Fri, 24 Jan 2025 16:07:03 +0100
Markus Burri <markus.burri@mt.com> wrote:
> Channel configuration doesn't work as expected.
> For FIELD_PREP the bit mask is needed and not the bit number.
>
> Fixes: 874bbd1219c7 ("iio: adc: ad7192: Use bitfield access macros")
needs to be part of the tags block. Hence no blank line here.
I'll tidy that up whilst applying. Applied and marked for stable.
Note I'll not push out my tree until I can rebase on rc1 after
next weekend as right now it would make a mess of linux-next.
>
> Signed-off-by: Markus Burri <markus.burri@mt.com>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 1c87db0e0460..c4effe8429c8 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon
>
> conf &= ~AD7192_CONF_CHAN_MASK;
> for_each_set_bit(i, scan_mask, 8)
> - conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i);
> + conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i));
>
> ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf);
> if (ret < 0)
>
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-25 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-24 15:07 [PATCH v2] iio: adc: ad7192: fix channel select Markus Burri
2025-01-25 12:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®