mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fix DWC3 documentation warning
@ 2025-01-19  2:18 Camila Alvarez
  2025-01-28  1:14 ` Thinh Nguyen
  0 siblings, 1 reply; 2+ messages in thread
From: Camila Alvarez @ 2025-01-19  2:18 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel, Camila Alvarez

Fixes ./drivers/usb/dwc3/core.h:983: warning: Function parameter or struct member 'sg' not described in 'dwc3_request'

Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
---
 drivers/usb/dwc3/core.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index f11570c8ffd0..ec74d5859343 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -942,6 +942,7 @@ struct dwc3_hwparams {
  * @request: struct usb_request to be transferred
  * @list: a list_head used for request queueing
  * @dep: struct dwc3_ep owning this request
+ * @sg: pointer to first incomplete sg 
  * @start_sg: pointer to the sg which should be queued next
  * @num_pending_sgs: counter to pending sgs
  * @remaining: amount of data remaining
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix DWC3 documentation warning
  2025-01-19  2:18 [PATCH] Fix DWC3 documentation warning Camila Alvarez
@ 2025-01-28  1:14 ` Thinh Nguyen
  0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2025-01-28  1:14 UTC (permalink / raw)
  To: Camila Alvarez; +Cc: Thinh Nguyen, Greg Kroah-Hartman, linux-usb, linux-kernel

On Sat, Jan 18, 2025, Camila Alvarez wrote:
> Fixes ./drivers/usb/dwc3/core.h:983: warning: Function parameter or struct member 'sg' not described in 'dwc3_request'
> 
> Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index f11570c8ffd0..ec74d5859343 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>   * @request: struct usb_request to be transferred
>   * @list: a list_head used for request queueing
>   * @dep: struct dwc3_ep owning this request
> + * @sg: pointer to first incomplete sg 
>   * @start_sg: pointer to the sg which should be queued next
>   * @num_pending_sgs: counter to pending sgs
>   * @remaining: amount of data remaining
> -- 
> 2.34.1
> 

This is not a correct fix.

See below fix that was already applied:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=686d4a2c26b49eaf6e817f16b7cb6c4b961aa7a7

BR,
Thinh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-28  1:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-19  2:18 [PATCH] Fix DWC3 documentation warning Camila Alvarez
2025-01-28  1:14 ` Thinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®