[PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type

[PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type

[Andy Shevchenko]

REGCACHE_NONE is the default type of the cache when not provided.
Drop unneeded explicit assignment to it.

Note, it's defined to 0, and if ever be redefined, it will break
literally a lot of the drivers, so it very unlikely to happen.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-realtek-rtl-snand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-realtek-rtl-snand.c b/drivers/spi/spi-realtek-rtl-snand.c
index cd0484041147..741cf2af3e91 100644
--- a/drivers/spi/spi-realtek-rtl-snand.c
+++ b/drivers/spi/spi-realtek-rtl-snand.c
@@ -364,7 +364,6 @@ static int rtl_snand_probe(struct platform_device *pdev)
 		.reg_bits	= 32,
 		.val_bits	= 32,
 		.reg_stride	= 4,
-		.cache_type	= REGCACHE_NONE,
 	};
 	int irq, ret;
 
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type

[Chris Packham]

Hi Andy,

On 30/01/2025 04:29, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
>
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

> ---
>   drivers/spi/spi-realtek-rtl-snand.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-realtek-rtl-snand.c b/drivers/spi/spi-realtek-rtl-snand.c
> index cd0484041147..741cf2af3e91 100644
> --- a/drivers/spi/spi-realtek-rtl-snand.c
> +++ b/drivers/spi/spi-realtek-rtl-snand.c
> @@ -364,7 +364,6 @@ static int rtl_snand_probe(struct platform_device *pdev)
>   		.reg_bits	= 32,
>   		.val_bits	= 32,
>   		.reg_stride	= 4,
> -		.cache_type	= REGCACHE_NONE,
>   	};
>   	int irq, ret;
>   

Re: [PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type

[Mark Brown]

On Wed, 29 Jan 2025 17:29:25 +0200, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
> 
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type
      commit: c1ac98492d1584d31f335d233a5cd7a4d4116e5a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark