mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fred Treven <ftreven@opensource.cirrus.com>
To: Simon Trimmer <simont@opensource.cirrus.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Fred Treven <ftreven@opensource.cirrus.com>,
	<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/7] firmware: cs_dsp: Fix error checking in wseq_write()
Date: Fri, 31 Jan 2025 13:56:32 -0600	[thread overview]
Message-ID: <20250131195639.1784933-2-ftreven@opensource.cirrus.com> (raw)
In-Reply-To: <20250131195639.1784933-1-ftreven@opensource.cirrus.com>

cs_dsp_coeff_write_ctrl() may return a non-zero value (1)
upon success. Change error checking in the write sequencer
code such that it checks for negative errnos rather than
any non-zero value when using this function.

Signed-off-by: Fred Treven <ftreven@opensource.cirrus.com>
---
 drivers/firmware/cirrus/cs_dsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c
index 5365e9a43000..56315b0b5583 100644
--- a/drivers/firmware/cirrus/cs_dsp.c
+++ b/drivers/firmware/cirrus/cs_dsp.c
@@ -3702,7 +3702,7 @@ int cs_dsp_wseq_write(struct cs_dsp *dsp, struct cs_dsp_wseq *wseq,
 
 		ret = cs_dsp_coeff_write_ctrl(wseq->ctl, op_end->offset / sizeof(u32),
 					      &op_end->data, sizeof(u32));
-		if (ret)
+		if (ret < 0)
 			goto op_new_free;
 
 		list_add_tail(&op_new->list, &op_end->list);
@@ -3710,7 +3710,7 @@ int cs_dsp_wseq_write(struct cs_dsp *dsp, struct cs_dsp_wseq *wseq,
 
 	ret = cs_dsp_coeff_write_ctrl(wseq->ctl, op_new->offset / sizeof(u32),
 				      words, new_op_size);
-	if (ret)
+	if (ret < 0)
 		goto op_new_free;
 
 	return 0;
-- 
2.34.1


       reply	other threads:[~2025-01-31 20:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250131195639.1784933-1-ftreven@opensource.cirrus.com>
2025-01-31 19:56 ` Fred Treven [this message]
2025-02-02 17:34   ` Markus Elfring
2025-02-04 10:03   ` Charles Keepax
2025-01-31 19:56 ` [PATCH 2/7] firmware: cs_dsp: Check for valid num_regs in cs_dsp_wseq_multi_write() Fred Treven
2025-02-04 10:06   ` Charles Keepax
2025-02-04 21:51     ` Fredrik Treven
2025-01-31 19:56 ` [PATCH 3/7] firmware: cs_dsp: Add ability to load multiple coefficient files Fred Treven
2025-02-04 10:10   ` Charles Keepax
2025-02-04 22:05     ` Fredrik Treven
2025-01-31 19:56 ` [PATCH 4/7] dt-bindings: mfd: cirrus,cs40l26: Support for CS40L26 Fred Treven
2025-02-02 14:04   ` Krzysztof Kozlowski
2025-02-04 22:18     ` Fredrik Treven
2025-02-05  7:29       ` Krzysztof Kozlowski
2025-01-31 19:56 ` [PATCH 5/7] mfd: cs40l26: Add support for CS40L26 core driver Fred Treven
2025-01-31 19:56 ` [PATCH 6/7] ASoC: cs40l26: Support I2S streaming to CS40L26 Fred Treven
2025-02-03 12:23   ` Mark Brown
2025-02-04 21:54     ` Fredrik Treven
2025-01-31 19:56 ` [PATCH 7/7] Input: cs40l26 - Add support for CS40L26 haptic driver Fred Treven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250131195639.1784933-2-ftreven@opensource.cirrus.com \
    --to=ftreven@opensource.cirrus.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=simont@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®