* [PATCH v2] usb: usb251xb: silence EPROBE_DEFER error on boot
@ 2025-02-03 6:33 Dominique Martinet
2025-02-03 13:21 ` Richard Leitner
0 siblings, 1 reply; 2+ messages in thread
From: Dominique Martinet @ 2025-02-03 6:33 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Dominique Martinet
Use dev_err_probe to silence EPROBE_DEFER error on boot:
[ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
Changes in v2:
- removed redundant error code in message and brace
- Link to v1: https://lore.kernel.org/r/20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com
---
drivers/usb/misc/usb251xb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index e24cdb667307802b9eee856e20744ebf694395e8..4fb453ca545013f8b89c43d3bb5cc6d1c53b39c9 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -636,10 +636,8 @@ static int usb251xb_probe(struct usb251xb *hub)
if (np && usb_data) {
err = usb251xb_get_ofdata(hub, usb_data);
- if (err) {
- dev_err(dev, "failed to get ofdata: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(dev, err, "failed to get ofdata\n");
}
/*
---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250203-defer_usb1-254070d18cc9
Best regards,
--
Dominique Martinet <dominique.martinet@atmark-techno.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: usb251xb: silence EPROBE_DEFER error on boot
2025-02-03 6:33 [PATCH v2] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
@ 2025-02-03 13:21 ` Richard Leitner
0 siblings, 0 replies; 2+ messages in thread
From: Richard Leitner @ 2025-02-03 13:21 UTC (permalink / raw)
To: Dominique Martinet; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Mon, Feb 03, 2025 at 03:33:49PM +0900, Dominique Martinet wrote:
> Use dev_err_probe to silence EPROBE_DEFER error on boot:
> [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
>
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> Changes in v2:
> - removed redundant error code in message and brace
> - Link to v1: https://lore.kernel.org/r/20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com
> ---
> drivers/usb/misc/usb251xb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index e24cdb667307802b9eee856e20744ebf694395e8..4fb453ca545013f8b89c43d3bb5cc6d1c53b39c9 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -636,10 +636,8 @@ static int usb251xb_probe(struct usb251xb *hub)
>
> if (np && usb_data) {
> err = usb251xb_get_ofdata(hub, usb_data);
> - if (err) {
> - dev_err(dev, "failed to get ofdata: %d\n", err);
> - return err;
> - }
> + if (err)
> + return dev_err_probe(dev, err, "failed to get ofdata\n");
> }
>
> /*
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb1-254070d18cc9
Acked-by: Richard Leitner <richard.leitner@linux.dev>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-03 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-03 6:33 [PATCH v2] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 13:21 ` Richard Leitner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®