From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Antoni Pokusinski <apokusinski01@gmail.com>, <jic23@kernel.org>,
<lars@metafoo.de>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: magnetometer: si7210: fix magnetic field measurement scale
Date: Mon, 3 Feb 2025 15:27:40 +0000 [thread overview]
Message-ID: <20250203152740.0000085e@huawei.com> (raw)
In-Reply-To: <Z6CLw5h5EwDGanl-@smile.fi.intel.com>
On Mon, 3 Feb 2025 11:26:27 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, Feb 02, 2025 at 11:07:10AM +0100, Antoni Pokusinski wrote:
> > Applying the current scale value to the raw magnetic field measurements
> > gives the result in mT.
> >
> > Fix the scale by increasing it 10 times, so that the final result after
> > applying the scale is in Gauss.
>
> No objections against this change, just wondering since these are
> the ABI changes (correct?) how should we really handle them in case
> some of the user space stuff already relies on 'bad' values?
>
If it's broken wrt to the published ABI (and hence what other sensors
are exporting) then not a whole lot we can do other than
backport the fix. This is one of the few cases where ABI backwards
compatibility comes second :(
Jonathan
next prev parent reply other threads:[~2025-02-03 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 10:07 Antoni Pokusinski
2025-02-03 9:26 ` Andy Shevchenko
2025-02-03 15:27 ` Jonathan Cameron [this message]
2025-02-03 19:39 ` Antoni Pokusinski
2025-02-04 19:24 ` Jonathan Cameron
2025-02-08 13:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203152740.0000085e@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apokusinski01@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®