mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fuse: don't set file->private_data in fuse_conn_waiting_read
@ 2025-02-04 15:04 Jeff Layton
  2025-02-05 18:13 ` Joanne Koong
  2025-02-14 10:17 ` Miklos Szeredi
  0 siblings, 2 replies; 5+ messages in thread
From: Jeff Layton @ 2025-02-04 15:04 UTC (permalink / raw)
  To: Miklos Szeredi; +Cc: linux-fsdevel, linux-kernel, Jeff Layton

I see no reason to set the private_data on the file to this value. Just
grab the result of the atomic_read() and output it without setting
private_data.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/fuse/control.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/fuse/control.c b/fs/fuse/control.c
index 2a730d88cc3bdb50ea1f8a3185faad5f05fc6e74..17ef07cf0c38e44bd7eadb3450bd53a8acc5e885 100644
--- a/fs/fuse/control.c
+++ b/fs/fuse/control.c
@@ -49,18 +49,17 @@ static ssize_t fuse_conn_waiting_read(struct file *file, char __user *buf,
 {
 	char tmp[32];
 	size_t size;
+	int value;
 
 	if (!*ppos) {
-		long value;
 		struct fuse_conn *fc = fuse_ctl_file_conn_get(file);
 		if (!fc)
 			return 0;
 
 		value = atomic_read(&fc->num_waiting);
-		file->private_data = (void *)value;
 		fuse_conn_put(fc);
 	}
-	size = sprintf(tmp, "%ld\n", (long)file->private_data);
+	size = sprintf(tmp, "%d\n", value);
 	return simple_read_from_buffer(buf, len, ppos, tmp, size);
 }
 

---
base-commit: 9afd7336f3acbe5678cca3b3bc5baefb51ce9564
change-id: 20250204-fuse-fixes-03882c05c1b1

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-02-14 13:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-04 15:04 [PATCH] fuse: don't set file->private_data in fuse_conn_waiting_read Jeff Layton
2025-02-05 18:13 ` Joanne Koong
2025-02-14 10:17 ` Miklos Szeredi
2025-02-14 12:58   ` Jeff Layton
2025-02-14 13:04     ` Miklos Szeredi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®