From: Maxime Ripard <mripard@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 09/10] drm/bridge: allow limiting I2S formats
Date: Wed, 5 Feb 2025 15:29:31 +0100 [thread overview]
Message-ID: <20250205-eager-laughing-nightingale-de5cab@houat> (raw)
In-Reply-To: <7nawswhaddasa4a2sytwspq62s4a2di3ukemfqsc3ueh2lftzl@kjq42eoq3ram>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Wed, Jan 29, 2025 at 01:45:56AM +0200, Dmitry Baryshkov wrote:
> On Tue, Jan 28, 2025 at 05:11:16PM +0100, Maxime Ripard wrote:
> > On Sun, Jan 26, 2025 at 03:29:14PM +0200, Dmitry Baryshkov wrote:
> > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> > > index b55e80a57758e8b652eac0cd01cb245a04e221f5..d16af5fe90cb48f6671e798d9dee61a359c9233f 100644
> > > --- a/include/drm/drm_bridge.h
> > > +++ b/include/drm/drm_bridge.h
> > > @@ -920,6 +920,11 @@ struct drm_bridge {
> > > */
> > > int hdmi_audio_max_i2s_playback_channels;
> > >
> > > + /**
> > > + * @hdmi_audio_i2s_formats: supported I2S formats, optional
> > > + */
> > > + u64 hdmi_audio_i2s_formats;
> > > +
> >
> > We should document what the default value is if it's optional.
>
> "The default is to allow all formats supported by the corresponding
> I2S bus driver." Does that sound fine from your POV?
Yep, sounds good.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2025-02-05 14:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 13:29 [PATCH v3 00/10] drm/display: generic HDMI CEC helpers Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 01/10] drm/connector: add CEC-related fields Dmitry Baryshkov
2025-01-28 10:33 ` Maxime Ripard
2025-01-28 13:12 ` Dmitry Baryshkov
2025-02-05 14:28 ` Maxime Ripard
2025-02-06 3:08 ` Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 02/10] drm/display: add CEC helpers code Dmitry Baryshkov
2025-01-28 10:36 ` Maxime Ripard
2025-01-28 12:17 ` Dmitry Baryshkov
2025-02-05 14:27 ` Maxime Ripard
2025-02-05 15:01 ` Dmitry Baryshkov
2025-02-19 9:19 ` Maxime Ripard
2025-01-26 13:29 ` [PATCH v3 03/10] drm/display: hdmi-state-helper: handle CEC physical address Dmitry Baryshkov
2025-01-26 14:10 ` Dmitry Baryshkov
2025-01-28 10:29 ` Maxime Ripard
2025-01-26 13:29 ` [PATCH v3 04/10] drm/vc4: hdmi: switch to generic CEC helpers Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 05/10] drm/display: bridge-connector: hook in CEC notifier support Dmitry Baryshkov
2025-01-28 16:14 ` Maxime Ripard
2025-01-28 21:47 ` Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 06/10] drm/bridge: move private data to the end of the struct Dmitry Baryshkov
2025-01-28 16:08 ` Maxime Ripard
2025-01-26 13:29 ` [PATCH v3 07/10] drm/display: hdmi-cec-helper: add bridge-related functions Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 08/10] drm/display: bridge-connector: handle CEC adapters Dmitry Baryshkov
2025-01-28 16:14 ` Maxime Ripard
2025-01-28 23:44 ` Dmitry Baryshkov
2025-01-29 16:44 ` Neil Armstrong
2025-01-29 18:32 ` Dmitry Baryshkov
2025-01-26 13:29 ` [PATCH v3 09/10] drm/bridge: allow limiting I2S formats Dmitry Baryshkov
2025-01-28 16:11 ` Maxime Ripard
2025-01-28 23:45 ` Dmitry Baryshkov
2025-02-05 14:29 ` Maxime Ripard [this message]
2025-01-26 13:29 ` [PATCH v3 10/10] drm/bridge: adv7511: switch to the HDMI connector helpers Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205-eager-laughing-nightingale-de5cab@houat \
--to=mripard@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®