From: Isaac Scott <isaac.scott@ideasonboard.com>
To: michael.hennerich@analog.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
linux-kernel@vger.kernel.org,
Isaac Scott <isaac.scott@ideasonboard.com>
Subject: [PATCH 1/1] regulator: ad5398: Correct the SW_POWER_DOWN bit number
Date: Thu, 6 Feb 2025 12:24:59 +0000 [thread overview]
Message-ID: <20250206122459.197985-2-isaac.scott@ideasonboard.com> (raw)
In-Reply-To: <20250206122459.197985-1-isaac.scott@ideasonboard.com>
The datasheet for the AD5398 regulator indicates that the Soft power
down bit is bit 15, not 16 as represented in the driver. Correct this to
ensure the functionality is implemented correctly.
Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com>
---
drivers/regulator/ad5398.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 0274f41d0233..eb2a666a45cb 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -16,7 +16,7 @@
#include <linux/regulator/machine.h>
#include <linux/regulator/of_regulator.h>
-#define AD5398_SW_POWER_DOWN BIT(16)
+#define AD5398_SW_POWER_DOWN BIT(15)
struct ad5398_chip_info {
struct i2c_client *client;
--
2.43.0
next prev parent reply other threads:[~2025-02-06 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 12:24 [PATCH 0/1] regulator: ad5398: Correct " Isaac Scott
2025-02-06 12:24 ` Isaac Scott [this message]
2025-02-06 12:28 ` [PATCH 1/1] regulator: ad5398: Correct the " Mark Brown
2025-02-06 12:45 ` Isaac Scott
2025-02-06 12:58 ` Mark Brown
2025-02-06 13:28 ` Isaac Scott
2025-02-06 13:44 ` Mark Brown
2025-02-06 13:57 ` Isaac Scott
2025-02-06 14:03 ` Mark Brown
2025-02-06 12:27 ` [PATCH 0/1] regulator: ad5398: Correct " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2025-02-06 12:21 Isaac Scott
2025-02-06 12:21 ` [PATCH 1/1] regulator: ad5398: Correct the " Isaac Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206122459.197985-2-isaac.scott@ideasonboard.com \
--to=isaac.scott@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®