mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Isaac Scott <isaac.scott@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: michael.hennerich@analog.com, lgirdwood@gmail.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: ad5398: Correct the SW_POWER_DOWN bit number
Date: Thu, 06 Feb 2025 12:45:28 +0000	[thread overview]
Message-ID: <2a0f24c61de73f7bd2bb495d697dcedd8462f4c0.camel@ideasonboard.com> (raw)
In-Reply-To: <c29affda-e769-4658-bb74-3b8c273e8262@sirena.org.uk>

Hi Mark,

On Thu, 2025-02-06 at 12:28 +0000, Mark Brown wrote:
> On Thu, Feb 06, 2025 at 12:24:59PM +0000, Isaac Scott wrote:
> > The datasheet for the AD5398 regulator indicates that the Soft
> > power
> > down bit is bit 15, not 16 as represented in the driver. Correct
> > this to
> > ensure the functionality is implemented correctly.
> 
> This doesn't apply against current code, please check and resend.

I have checked, and it applies on top of linux-next next-20250206,
which includes my previous patch you have already applied:

[1/3] regulator: ad5398: change enable bit name to improve readibility
      commit: 19d022d67d7353f0e6e9ba255435d3de93862ac4
[3/3] regulator: ad5398: Add device tree support
      commit: 5a6a461079decea452fdcae955bccecf92e07e97

Have I applied it to the wrong branch?

Thank you very much,

Best wishes,

Isaac



  reply	other threads:[~2025-02-06 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 12:24 [PATCH 0/1] regulator: ad5398: Correct " Isaac Scott
2025-02-06 12:24 ` [PATCH 1/1] regulator: ad5398: Correct the " Isaac Scott
2025-02-06 12:28   ` Mark Brown
2025-02-06 12:45     ` Isaac Scott [this message]
2025-02-06 12:58       ` Mark Brown
2025-02-06 13:28         ` Isaac Scott
2025-02-06 13:44           ` Mark Brown
2025-02-06 13:57             ` Isaac Scott
2025-02-06 14:03               ` Mark Brown
2025-02-06 12:27 ` [PATCH 0/1] regulator: ad5398: Correct " Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2025-02-06 12:21 Isaac Scott
2025-02-06 12:21 ` [PATCH 1/1] regulator: ad5398: Correct the " Isaac Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a0f24c61de73f7bd2bb495d697dcedd8462f4c0.camel@ideasonboard.com \
    --to=isaac.scott@ideasonboard.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®