mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef@layalina.io>
To: zihan zhou <15645113830zzh@gmail.com>
Cc: bsegall@google.com, dietmar.eggemann@arm.com,
	juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
	mgorman@suse.de, mingo@redhat.com, peterz@infradead.org,
	rostedt@goodmis.org, vincent.guittot@linaro.org,
	vschneid@redhat.com
Subject: Re: [PATCH V3 1/2] sched: Reduce the default slice to avoid tasks getting an extra tick
Date: Mon, 10 Feb 2025 01:29:31 +0000	[thread overview]
Message-ID: <20250210012931.ym337oexdcjmwwzv@airbuntu> (raw)
In-Reply-To: <20250208075322.13139-1-15645113830zzh@gmail.com>

On 02/08/25 15:53, zihan zhou wrote:
> The old default value for slice is 0.75 msec * (1 + ilog(ncpus)) which
> means that we have a default slice of
> 0.75 for 1 cpu
> 1.50 up to 3 cpus
> 2.25 up to 7 cpus
> 3.00 for 8 cpus and above.

I brought the topic up of these magic values with Peter and Vincent in LPC as
I think this logic is confusing. I have nothing against your patch, but if the
maintainers agree I am in favour of removing it completely in favour of setting
it to a single value that is the same across all systems.

I do think 1ms makes more sense as a default value given how modern workloads
need faster responsiveness across the board. But keeping it 3ms to avoid much
disturbance would be fine. We could also make it equal to TICK_MSEC (this
define doesn't exist) if it is higher than 3ms.

Do you use HZ=100 by the way? If yes, are you able to share the reasons? This
configuration is too aggressive and bad for latencies and I doubt this tweak of
the formula will make things better to them anyway.

  reply	other threads:[~2025-02-10  1:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08  7:48 [PATCH V3 0/2] " zihan zhou
2025-02-08  7:53 ` [PATCH V3 1/2] " zihan zhou
2025-02-10  1:29   ` Qais Yousef [this message]
2025-02-10  6:18     ` zihan zhou
2025-02-10 22:55       ` Qais Yousef
2025-02-10  9:13     ` Peter Zijlstra
2025-02-10 23:05       ` Qais Yousef
2025-02-22  3:19         ` zihan zhou
2025-02-23  0:08           ` Qais Yousef
2025-02-24 14:15       ` Vincent Guittot
2025-02-25  0:25         ` Qais Yousef
2025-02-25  1:29           ` Vincent Guittot
2025-02-25 10:13             ` Vincent Guittot
2025-02-25 13:06               ` Qais Yousef
2025-02-14  3:33   ` K Prateek Nayak
2025-02-22  3:02     ` zihan zhou
2025-03-07  4:10       ` K Prateek Nayak
2025-03-14  1:49         ` zihan zhou
2025-02-15 10:55   ` [tip: sched/core] " tip-bot2 for zihan zhou
2025-02-08  7:57 ` [PATCH V3 2/2] " zihan zhou
2025-02-08 19:32   ` Vincent Guittot
2025-02-10  6:26     ` zihan zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210012931.ym337oexdcjmwwzv@airbuntu \
    --to=qyousef@layalina.io \
    --cc=15645113830zzh@gmail.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®