mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zihan zhou <15645113830zzh@gmail.com>
To: vincent.guittot@linaro.org
Cc: 15645113830zzh@gmail.com, bsegall@google.com,
	dietmar.eggemann@arm.com, juri.lelli@redhat.com,
	linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
	peterz@infradead.org, rostedt@goodmis.org, vschneid@redhat.com
Subject: Re: [PATCH V3 2/2] sched: Reduce the default slice to avoid tasks getting an extra tick
Date: Mon, 10 Feb 2025 14:26:59 +0800	[thread overview]
Message-ID: <20250210062657.301669-1-15645113830zzh@gmail.com> (raw)
In-Reply-To: <CAKfTPtDuCJTOJ0WvtEJLmkanZCWLfKG-D5r8+8p7EWGin2mGRw@mail.gmail.com>


> > Update sysctl_sched_base_slice with debugfs, limit its value and
> > update normalized_sysctl_sched_base_slice.
> >
> > Rename the function sched_update_scaling to sched_update_scaling_or_slice,
> > it is no longer related to CONFIG_SMP and return void, as the previous
> > function always returns 0 and there is no need to judge the return value
> > again, just like the function update_sysctl.
> >
> > Signed-off-by: zihan zhou <15645113830zzh@gmail.com>
> > Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> 
> My Reviewed applied only for patch 1 not patch 2. That's also why I
> asked you to split it. Patch 1 makes sense for me but I don't see the
> benefit of patch 2

I'm sorry I misunderstood your meaning. Do I need to resubmit or just
ignore this patch?

      reply	other threads:[~2025-02-10  6:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08  7:48 [PATCH V3 0/2] " zihan zhou
2025-02-08  7:53 ` [PATCH V3 1/2] " zihan zhou
2025-02-10  1:29   ` Qais Yousef
2025-02-10  6:18     ` zihan zhou
2025-02-10 22:55       ` Qais Yousef
2025-02-10  9:13     ` Peter Zijlstra
2025-02-10 23:05       ` Qais Yousef
2025-02-22  3:19         ` zihan zhou
2025-02-23  0:08           ` Qais Yousef
2025-02-24 14:15       ` Vincent Guittot
2025-02-25  0:25         ` Qais Yousef
2025-02-25  1:29           ` Vincent Guittot
2025-02-25 10:13             ` Vincent Guittot
2025-02-25 13:06               ` Qais Yousef
2025-02-14  3:33   ` K Prateek Nayak
2025-02-22  3:02     ` zihan zhou
2025-03-07  4:10       ` K Prateek Nayak
2025-03-14  1:49         ` zihan zhou
2025-02-15 10:55   ` [tip: sched/core] " tip-bot2 for zihan zhou
2025-02-08  7:57 ` [PATCH V3 2/2] " zihan zhou
2025-02-08 19:32   ` Vincent Guittot
2025-02-10  6:26     ` zihan zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210062657.301669-1-15645113830zzh@gmail.com \
    --to=15645113830zzh@gmail.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®