[PATCH v1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon

[PATCH v1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon

[Sebastian Reichel]

From: Sebastian Reichel <sre@kernel.org>

The Lenovo Thinkpad T14s Gen6 Snapdragon is currently sold with three
different panel versions: OLED, Low Power IPS or IPS with Touchscreen.

My Low Power IPS version had this panel and the kernel complained
about not knowing any details.  I don't have any panel documentation,
but as far as I can see the same timings for the already supported
CSO panel also work for this one.

The raw EDID is:

00 ff ff ff ff ff ff 00 0e 6f 13 14 00 00 00 00
00 1e 01 04 a5 1e 13 78 03 82 53 a4 55 4d 9b 24
0d 51 55 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 35 3c 80 a0 70 b0 23 40 30 20
36 00 2e bd 10 00 00 18 00 00 00 fd 00 30 3c 4a
4a 0f 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
53 4f 54 20 54 33 0a 20 20 20 20 20 00 00 00 fe
00 4d 4e 45 30 30 37 4a 41 31 2d 32 0a 20 00 8b

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
Hi,

I'm running my kernels on the laptop as a daily driver with this patch
for ca. 3 weeks now and haven't noticed any problems. In case they have
better documentation I added some people in Cc, that have send patches
for the T14s DT and thus should have at least one of them.

Greetings,

-- Sebastian
---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index f8511fe5fb0d..7af65fb69075 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1951,6 +1951,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('C', 'M', 'N', 0x14e5, &delay_200_500_e80_d50, "N140HGA-EA1"),
 
 	EDP_PANEL_ENTRY('C', 'S', 'O', 0x1200, &delay_200_500_e50_p2e200, "MNC207QS1-1"),
+	EDP_PANEL_ENTRY('C', 'S', 'O', 0x1413, &delay_200_500_e50_p2e200, "MNE007JA1-2"),
 
 	EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50, "MNB601LS1-1"),
 	EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50, "MNB601LS1-4"),
-- 
2.47.2

Re: [PATCH v1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon

[Doug Anderson]

Hi,

On Mon, Feb 10, 2025 at 5:43 PM Sebastian Reichel <sre@ring0.de> wrote:
>
> From: Sebastian Reichel <sre@kernel.org>
>
> The Lenovo Thinkpad T14s Gen6 Snapdragon is currently sold with three
> different panel versions: OLED, Low Power IPS or IPS with Touchscreen.
>
> My Low Power IPS version had this panel and the kernel complained
> about not knowing any details.  I don't have any panel documentation,
> but as far as I can see the same timings for the already supported
> CSO panel also work for this one.
>
> The raw EDID is:
>
> 00 ff ff ff ff ff ff 00 0e 6f 13 14 00 00 00 00
> 00 1e 01 04 a5 1e 13 78 03 82 53 a4 55 4d 9b 24
> 0d 51 55 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 35 3c 80 a0 70 b0 23 40 30 20
> 36 00 2e bd 10 00 00 18 00 00 00 fd 00 30 3c 4a
> 4a 0f 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 53 4f 54 20 54 33 0a 20 20 20 20 20 00 00 00 fe
> 00 4d 4e 45 30 30 37 4a 41 31 2d 32 0a 20 00 8b
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> Hi,
>
> I'm running my kernels on the laptop as a daily driver with this patch
> for ca. 3 weeks now and haven't noticed any problems. In case they have
> better documentation I added some people in Cc, that have send patches
> for the T14s DT and thus should have at least one of them.
>
> Greetings,
>
> -- Sebastian
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)

If someone has better timings or finds problems with these then feel
free to submit a followup, but until then this meets the bar we've
established of at least documenting the EDID and the fact that the
timings are uncertain in the commit message.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next:

[1/1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon
      commit: 50625eab3972e5d37dcf3a250d9e3cdecbd6c13b