* [PATCH V4 1/4] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT
2025-02-12 0:07 [PATCH V4 0/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
@ 2025-02-12 0:07 ` Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-12 0:07 UTC (permalink / raw)
To: x86, linux-kernel
Cc: pbonzini, seanjc, erdemaktas, ackerleytng, jxgao, sagis, oupton,
pgonda, kirill, dave.hansen, linux-coco, chao.p.peng,
isaku.yamahata, sathyanarayanan.kuppuswamy, Kirill A. Shutemov,
stable, Andi Kleen, Tony Luck, Vishal Annapurve
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CONFIG_PARAVIRT_XXL is mainly defined/used by XEN PV guests. For
other VM guest types, features supported under CONFIG_PARAVIRT
are self sufficient. CONFIG_PARAVIRT mainly provides support for
TLB flush operations and time related operations.
For TDX guest as well, paravirt calls under CONFIG_PARVIRT meets
most of its requirement except the need of HLT and SAFE_HLT
paravirt calls, which is currently defined under
CONFIG_PARAVIRT_XXL.
Since enabling CONFIG_PARAVIRT_XXL is too bloated for TDX guest
like platforms, move HLT and SAFE_HLT paravirt calls under
CONFIG_PARAVIRT.
Moving HLT and SAFE_HLT paravirt calls are not fatal and should not
break any functionality for current users of CONFIG_PARAVIRT.
Cc: stable@vger.kernel.org
Fixes: bfe6ed0c6727 ("x86/tdx: Add HLT support for TDX guests")
Co-developed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Vishal Annapurve <vannapurve@google.com>
---
arch/x86/include/asm/irqflags.h | 40 +++++++++++++++------------
arch/x86/include/asm/paravirt.h | 20 +++++++-------
arch/x86/include/asm/paravirt_types.h | 3 +-
arch/x86/kernel/paravirt.c | 14 ++++++----
4 files changed, 41 insertions(+), 36 deletions(-)
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index cf7fc2b8e3ce..1c2db11a2c3c 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -76,6 +76,28 @@ static __always_inline void native_local_irq_restore(unsigned long flags)
#endif
+#ifndef CONFIG_PARAVIRT
+#ifndef __ASSEMBLY__
+/*
+ * Used in the idle loop; sti takes one instruction cycle
+ * to complete:
+ */
+static __always_inline void arch_safe_halt(void)
+{
+ native_safe_halt();
+}
+
+/*
+ * Used when interrupts are already enabled or to
+ * shutdown the processor:
+ */
+static __always_inline void halt(void)
+{
+ native_halt();
+}
+#endif /* __ASSEMBLY__ */
+#endif /* CONFIG_PARAVIRT */
+
#ifdef CONFIG_PARAVIRT_XXL
#include <asm/paravirt.h>
#else
@@ -97,24 +119,6 @@ static __always_inline void arch_local_irq_enable(void)
native_irq_enable();
}
-/*
- * Used in the idle loop; sti takes one instruction cycle
- * to complete:
- */
-static __always_inline void arch_safe_halt(void)
-{
- native_safe_halt();
-}
-
-/*
- * Used when interrupts are already enabled or to
- * shutdown the processor:
- */
-static __always_inline void halt(void)
-{
- native_halt();
-}
-
/*
* For spinlocks, etc:
*/
diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index 041aff51eb50..29e7331a0c98 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -107,6 +107,16 @@ static inline void notify_page_enc_status_changed(unsigned long pfn,
PVOP_VCALL3(mmu.notify_page_enc_status_changed, pfn, npages, enc);
}
+static __always_inline void arch_safe_halt(void)
+{
+ PVOP_VCALL0(irq.safe_halt);
+}
+
+static inline void halt(void)
+{
+ PVOP_VCALL0(irq.halt);
+}
+
#ifdef CONFIG_PARAVIRT_XXL
static inline void load_sp0(unsigned long sp0)
{
@@ -170,16 +180,6 @@ static inline void __write_cr4(unsigned long x)
PVOP_VCALL1(cpu.write_cr4, x);
}
-static __always_inline void arch_safe_halt(void)
-{
- PVOP_VCALL0(irq.safe_halt);
-}
-
-static inline void halt(void)
-{
- PVOP_VCALL0(irq.halt);
-}
-
static inline u64 paravirt_read_msr(unsigned msr)
{
return PVOP_CALL1(u64, cpu.read_msr, msr);
diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
index fea56b04f436..abccfccc2e3f 100644
--- a/arch/x86/include/asm/paravirt_types.h
+++ b/arch/x86/include/asm/paravirt_types.h
@@ -120,10 +120,9 @@ struct pv_irq_ops {
struct paravirt_callee_save save_fl;
struct paravirt_callee_save irq_disable;
struct paravirt_callee_save irq_enable;
-
+#endif
void (*safe_halt)(void);
void (*halt)(void);
-#endif
} __no_randomize_layout;
struct pv_mmu_ops {
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index 1ccaa3397a67..c5bb980b8a67 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -110,6 +110,11 @@ int paravirt_disable_iospace(void)
return request_resource(&ioport_resource, &reserve_ioports);
}
+static noinstr void pv_native_safe_halt(void)
+{
+ native_safe_halt();
+}
+
#ifdef CONFIG_PARAVIRT_XXL
static noinstr void pv_native_write_cr2(unsigned long val)
{
@@ -125,11 +130,6 @@ static noinstr void pv_native_set_debugreg(int regno, unsigned long val)
{
native_set_debugreg(regno, val);
}
-
-static noinstr void pv_native_safe_halt(void)
-{
- native_safe_halt();
-}
#endif
struct pv_info pv_info = {
@@ -186,9 +186,11 @@ struct paravirt_patch_template pv_ops = {
.irq.save_fl = __PV_IS_CALLEE_SAVE(pv_native_save_fl),
.irq.irq_disable = __PV_IS_CALLEE_SAVE(pv_native_irq_disable),
.irq.irq_enable = __PV_IS_CALLEE_SAVE(pv_native_irq_enable),
+#endif /* CONFIG_PARAVIRT_XXL */
+
+ /* Irq HLT ops. */
.irq.safe_halt = pv_native_safe_halt,
.irq.halt = native_halt,
-#endif /* CONFIG_PARAVIRT_XXL */
/* Mmu ops. */
.mmu.flush_tlb_user = native_flush_tlb_local,
--
2.48.1.502.g6dc24dfdaf-goog
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt()
2025-02-12 0:07 [PATCH V4 0/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 1/4] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT Vishal Annapurve
@ 2025-02-12 0:07 ` Vishal Annapurve
2025-02-12 12:54 ` Kirill A. Shutemov
2025-02-12 0:07 ` [PATCH V4 3/4] x86/tdx: Emit warning if IRQs are enabled during HLT #VE handling Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine Vishal Annapurve
3 siblings, 1 reply; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-12 0:07 UTC (permalink / raw)
To: x86, linux-kernel
Cc: pbonzini, seanjc, erdemaktas, ackerleytng, jxgao, sagis, oupton,
pgonda, kirill, dave.hansen, linux-coco, chao.p.peng,
isaku.yamahata, sathyanarayanan.kuppuswamy, Vishal Annapurve,
stable
Direct HLT instruction execution causes #VEs for TDX VMs which is routed
to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow
so IRQs need to remain disabled until the TDCALL to ensure that pending
IRQs are correctly treated as wake events. So "sti;hlt" sequence needs to
be replaced with "TDCALL; raw_local_irq_enable()" for TDX VMs.
Commit bfe6ed0c6727 ("x86/tdx: Add HLT support for TDX guests")
prevented the idle routines from using "sti;hlt". But it missed the
paravirt routine which can be reached like this as an example:
acpi_safe_halt() =>
raw_safe_halt() =>
arch_safe_halt() =>
irq.safe_halt() =>
pv_native_safe_halt()
Modify tdx_safe_halt() to implement the sequence "TDCALL;
raw_local_irq_enable()" and invoke tdx_halt() from idle routine which just
executes TDCALL without changing state of interrupts. Introduce dependency
on CONFIG_PARAVIRT and override paravirt halt()/safe_halt() routines for
TDX VMs.
Cc: stable@vger.kernel.org
Fixes: bfe6ed0c6727 ("x86/tdx: Add HLT support for TDX guests")
Signed-off-by: Vishal Annapurve <vannapurve@google.com>
---
arch/x86/Kconfig | 1 +
arch/x86/coco/tdx/tdx.c | 18 +++++++++++++++++-
arch/x86/include/asm/tdx.h | 2 +-
arch/x86/kernel/process.c | 2 +-
4 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 87198d957e2f..afcdbc9693dc 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -902,6 +902,7 @@ config INTEL_TDX_GUEST
depends on X86_64 && CPU_SUP_INTEL
depends on X86_X2APIC
depends on EFI_STUB
+ depends on PARAVIRT
select ARCH_HAS_CC_PLATFORM
select X86_MEM_ENCRYPT
select X86_MCE
diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
index 32809a06dab4..ee67c1870e70 100644
--- a/arch/x86/coco/tdx/tdx.c
+++ b/arch/x86/coco/tdx/tdx.c
@@ -14,6 +14,7 @@
#include <asm/ia32.h>
#include <asm/insn.h>
#include <asm/insn-eval.h>
+#include <asm/paravirt_types.h>
#include <asm/pgtable.h>
#include <asm/set_memory.h>
#include <asm/traps.h>
@@ -398,7 +399,7 @@ static int handle_halt(struct ve_info *ve)
return ve_instr_len(ve);
}
-void __cpuidle tdx_safe_halt(void)
+void __cpuidle tdx_halt(void)
{
const bool irq_disabled = false;
@@ -409,6 +410,12 @@ void __cpuidle tdx_safe_halt(void)
WARN_ONCE(1, "HLT instruction emulation failed\n");
}
+static void __cpuidle tdx_safe_halt(void)
+{
+ tdx_halt();
+ raw_local_irq_enable();
+}
+
static int read_msr(struct pt_regs *regs, struct ve_info *ve)
{
struct tdx_module_args args = {
@@ -1109,6 +1116,15 @@ void __init tdx_early_init(void)
x86_platform.guest.enc_kexec_begin = tdx_kexec_begin;
x86_platform.guest.enc_kexec_finish = tdx_kexec_finish;
+ /*
+ * "sti;hlt" execution in TDX guests will induce a #VE in the STI-shadow
+ * which will enable interrupts before HLT TDCALL inocation possibly
+ * resulting in missed wakeup events. Modify all possible HLT
+ * execution paths to use TDCALL for performance/reliability reasons.
+ */
+ pv_ops.irq.safe_halt = tdx_safe_halt;
+ pv_ops.irq.halt = tdx_halt;
+
/*
* TDX intercepts the RDMSR to read the X2APIC ID in the parallel
* bringup low level code. That raises #VE which cannot be handled
diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
index b4b16dafd55e..393ee2dfaab1 100644
--- a/arch/x86/include/asm/tdx.h
+++ b/arch/x86/include/asm/tdx.h
@@ -58,7 +58,7 @@ void tdx_get_ve_info(struct ve_info *ve);
bool tdx_handle_virt_exception(struct pt_regs *regs, struct ve_info *ve);
-void tdx_safe_halt(void);
+void tdx_halt(void);
bool tdx_early_handle_ve(struct pt_regs *regs);
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 6da6769d7254..d11956a178df 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -934,7 +934,7 @@ void __init select_idle_routine(void)
static_call_update(x86_idle, mwait_idle);
} else if (cpu_feature_enabled(X86_FEATURE_TDX_GUEST)) {
pr_info("using TDX aware idle routine\n");
- static_call_update(x86_idle, tdx_safe_halt);
+ static_call_update(x86_idle, tdx_halt);
} else {
static_call_update(x86_idle, default_idle);
}
--
2.48.1.502.g6dc24dfdaf-goog
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt()
2025-02-12 0:07 ` [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
@ 2025-02-12 12:54 ` Kirill A. Shutemov
2025-02-13 17:33 ` Vishal Annapurve
0 siblings, 1 reply; 9+ messages in thread
From: Kirill A. Shutemov @ 2025-02-12 12:54 UTC (permalink / raw)
To: Vishal Annapurve
Cc: x86, linux-kernel, pbonzini, seanjc, erdemaktas, ackerleytng,
jxgao, sagis, oupton, pgonda, dave.hansen, linux-coco,
chao.p.peng, isaku.yamahata, sathyanarayanan.kuppuswamy, stable
On Wed, Feb 12, 2025 at 12:07:45AM +0000, Vishal Annapurve wrote:
> Direct HLT instruction execution causes #VEs for TDX VMs which is routed
> to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow
> so IRQs need to remain disabled until the TDCALL to ensure that pending
> IRQs are correctly treated as wake events. So "sti;hlt" sequence needs to
> be replaced with "TDCALL; raw_local_irq_enable()" for TDX VMs.
The last sentence is somewhat confusing.
Maybe drop it and add explanation that #VE handler doesn't have info about
STI shadow, enables interrupts before TDCALL which can lead to missed
wakeup events.
> @@ -409,6 +410,12 @@ void __cpuidle tdx_safe_halt(void)
> WARN_ONCE(1, "HLT instruction emulation failed\n");
> }
>
> +static void __cpuidle tdx_safe_halt(void)
> +{
> + tdx_halt();
> + raw_local_irq_enable();
What is justification for raw_? Why local_irq_enable() is not enough?
To very least, it has to be explained.
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt()
2025-02-12 12:54 ` Kirill A. Shutemov
@ 2025-02-13 17:33 ` Vishal Annapurve
0 siblings, 0 replies; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-13 17:33 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: x86, linux-kernel, pbonzini, seanjc, erdemaktas, ackerleytng,
jxgao, sagis, oupton, pgonda, dave.hansen, linux-coco,
chao.p.peng, isaku.yamahata, sathyanarayanan.kuppuswamy, stable
On Wed, Feb 12, 2025 at 4:54 AM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Wed, Feb 12, 2025 at 12:07:45AM +0000, Vishal Annapurve wrote:
> > Direct HLT instruction execution causes #VEs for TDX VMs which is routed
> > to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow
> > so IRQs need to remain disabled until the TDCALL to ensure that pending
> > IRQs are correctly treated as wake events. So "sti;hlt" sequence needs to
> > be replaced with "TDCALL; raw_local_irq_enable()" for TDX VMs.
>
> The last sentence is somewhat confusing.
>
> Maybe drop it and add explanation that #VE handler doesn't have info about
> STI shadow, enables interrupts before TDCALL which can lead to missed
> wakeup events.
Ack, will fix it in the next version.
>
> > @@ -409,6 +410,12 @@ void __cpuidle tdx_safe_halt(void)
> > WARN_ONCE(1, "HLT instruction emulation failed\n");
> > }
> >
> > +static void __cpuidle tdx_safe_halt(void)
> > +{
> > + tdx_halt();
> > + raw_local_irq_enable();
>
> What is justification for raw_? Why local_irq_enable() is not enough?
>
> To very least, it has to be explained.
Let me replace it with a more suitable arch specific <>_irq_enable()
function in the next version. Intention here is to just enable
interrupts.
>
> --
> Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V4 3/4] x86/tdx: Emit warning if IRQs are enabled during HLT #VE handling
2025-02-12 0:07 [PATCH V4 0/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 1/4] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 2/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
@ 2025-02-12 0:07 ` Vishal Annapurve
2025-02-12 0:07 ` [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine Vishal Annapurve
3 siblings, 0 replies; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-12 0:07 UTC (permalink / raw)
To: x86, linux-kernel
Cc: pbonzini, seanjc, erdemaktas, ackerleytng, jxgao, sagis, oupton,
pgonda, kirill, dave.hansen, linux-coco, chao.p.peng,
isaku.yamahata, sathyanarayanan.kuppuswamy, Vishal Annapurve,
Kirill A. Shutemov
Direct HLT instruction execution causes #VEs for TDX VMs which is routed
to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow
so IRQs need to remain disabled until the TDCALL to ensure that pending
IRQs are correctly treated as wake events.
Emit warning and fail emulation if IRQs are enabled during HLT #VE handling
to avoid running into scenarios where IRQ wake events are lost resulting in
indefinite HLT execution times.
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Vishal Annapurve <vannapurve@google.com>
---
arch/x86/coco/tdx/tdx.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
index ee67c1870e70..54baf93d9218 100644
--- a/arch/x86/coco/tdx/tdx.c
+++ b/arch/x86/coco/tdx/tdx.c
@@ -393,6 +393,14 @@ static int handle_halt(struct ve_info *ve)
{
const bool irq_disabled = irqs_disabled();
+ /*
+ * HLT with IRQs enabled is unsafe, as an IRQ that is intended to be a
+ * wake event may be consumed before requesting HLT emulation, leaving
+ * the vCPU blocking indefinitely.
+ */
+ if (WARN_ONCE(!irq_disabled, "HLT emulation with IRQs enabled"))
+ return -EIO;
+
if (__halt(irq_disabled))
return -EIO;
--
2.48.1.502.g6dc24dfdaf-goog
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine
2025-02-12 0:07 [PATCH V4 0/4] x86/tdx: Route safe halt execution via tdx_safe_halt() Vishal Annapurve
` (2 preceding siblings ...)
2025-02-12 0:07 ` [PATCH V4 3/4] x86/tdx: Emit warning if IRQs are enabled during HLT #VE handling Vishal Annapurve
@ 2025-02-12 0:07 ` Vishal Annapurve
2025-02-12 13:03 ` Kirill A. Shutemov
3 siblings, 1 reply; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-12 0:07 UTC (permalink / raw)
To: x86, linux-kernel
Cc: pbonzini, seanjc, erdemaktas, ackerleytng, jxgao, sagis, oupton,
pgonda, kirill, dave.hansen, linux-coco, chao.p.peng,
isaku.yamahata, sathyanarayanan.kuppuswamy, Vishal Annapurve
With explicit dependency on CONFIG_PARAVIRT and TDX specific
halt()/safe_halt() routines in place, default_idle() is safe to execute for
TDX VMs. Remove TDX specific idle routine override which is now
redundant.
Signed-off-by: Vishal Annapurve <vannapurve@google.com>
---
arch/x86/coco/tdx/tdx.c | 2 +-
arch/x86/include/asm/tdx.h | 2 --
arch/x86/kernel/process.c | 3 ---
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
index 54baf93d9218..3578f7f7a502 100644
--- a/arch/x86/coco/tdx/tdx.c
+++ b/arch/x86/coco/tdx/tdx.c
@@ -407,7 +407,7 @@ static int handle_halt(struct ve_info *ve)
return ve_instr_len(ve);
}
-void __cpuidle tdx_halt(void)
+static void __cpuidle tdx_halt(void)
{
const bool irq_disabled = false;
diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
index 393ee2dfaab1..6769d1da4c80 100644
--- a/arch/x86/include/asm/tdx.h
+++ b/arch/x86/include/asm/tdx.h
@@ -58,8 +58,6 @@ void tdx_get_ve_info(struct ve_info *ve);
bool tdx_handle_virt_exception(struct pt_regs *regs, struct ve_info *ve);
-void tdx_halt(void);
-
bool tdx_early_handle_ve(struct pt_regs *regs);
int tdx_mcall_get_report0(u8 *reportdata, u8 *tdreport);
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index d11956a178df..9b21989c283b 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -932,9 +932,6 @@ void __init select_idle_routine(void)
if (prefer_mwait_c1_over_halt()) {
pr_info("using mwait in idle threads\n");
static_call_update(x86_idle, mwait_idle);
- } else if (cpu_feature_enabled(X86_FEATURE_TDX_GUEST)) {
- pr_info("using TDX aware idle routine\n");
- static_call_update(x86_idle, tdx_halt);
} else {
static_call_update(x86_idle, default_idle);
}
--
2.48.1.502.g6dc24dfdaf-goog
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine
2025-02-12 0:07 ` [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine Vishal Annapurve
@ 2025-02-12 13:03 ` Kirill A. Shutemov
2025-02-13 17:40 ` Vishal Annapurve
0 siblings, 1 reply; 9+ messages in thread
From: Kirill A. Shutemov @ 2025-02-12 13:03 UTC (permalink / raw)
To: Vishal Annapurve
Cc: x86, linux-kernel, pbonzini, seanjc, erdemaktas, ackerleytng,
jxgao, sagis, oupton, pgonda, dave.hansen, linux-coco,
chao.p.peng, isaku.yamahata, sathyanarayanan.kuppuswamy
On Wed, Feb 12, 2025 at 12:07:47AM +0000, Vishal Annapurve wrote:
> With explicit dependency on CONFIG_PARAVIRT and TDX specific
> halt()/safe_halt() routines in place, default_idle() is safe to execute for
> TDX VMs. Remove TDX specific idle routine override which is now
> redundant.
I am not convinced that it is good idea.
It adds two needless flipping of IF in the hot path: first enabling
interrupts in tdx_safe_halt() and disabling it back in default_idle().
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine
2025-02-12 13:03 ` Kirill A. Shutemov
@ 2025-02-13 17:40 ` Vishal Annapurve
0 siblings, 0 replies; 9+ messages in thread
From: Vishal Annapurve @ 2025-02-13 17:40 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: x86, linux-kernel, pbonzini, seanjc, erdemaktas, ackerleytng,
jxgao, sagis, oupton, pgonda, dave.hansen, linux-coco,
chao.p.peng, isaku.yamahata, sathyanarayanan.kuppuswamy
On Wed, Feb 12, 2025 at 5:03 AM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Wed, Feb 12, 2025 at 12:07:47AM +0000, Vishal Annapurve wrote:
> > With explicit dependency on CONFIG_PARAVIRT and TDX specific
> > halt()/safe_halt() routines in place, default_idle() is safe to execute for
> > TDX VMs. Remove TDX specific idle routine override which is now
> > redundant.
>
> I am not convinced that it is good idea.
>
> It adds two needless flipping of IF in the hot path: first enabling
> interrupts in tdx_safe_halt() and disabling it back in default_idle().
>
IIUC, the aspect of flipping IF in the hot path twice is also
applicable to default_idle() that gets executed for non-confidential
VMs. I agree that it's redundant for TDX VMs and if there is strong
consensus here, I can drop this cleanup in the next version.
> --
> Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 9+ messages in thread