From: Anusha Srivatsa <asrivats@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Joel Selvaraj <jo@jsfamily.in>,
Ondrej Jirman <megi@xff.cz>,
Javier Martinez Canillas <javierm@redhat.com>,
Jianhua Lu <lujianhua000@gmail.com>,
Robert Chiras <robert.chiras@nxp.com>,
Artur Weber <aweber.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Anusha Srivatsa <asrivats@redhat.com>
Subject: [PATCH 19/20] drm/panel: Remove deprecated functions
Date: Thu, 13 Feb 2025 15:44:36 -0500 [thread overview]
Message-ID: <20250213-mipi_cocci_multi-v1-19-67d94ff319cc@redhat.com> (raw)
In-Reply-To: <20250213-mipi_cocci_multi-v1-0-67d94ff319cc@redhat.com>
With transition to newer functions, remove
older ones that are no longer used.
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
---
drivers/gpu/drm/drm_mipi_dsi.c | 56 ------------------------------------------
include/drm/drm_mipi_dsi.h | 47 -----------------------------------
2 files changed, 103 deletions(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 5e5c5f84daacc6913a73f9dda0f49cc78f83479a..33f68d4057aadd772afe6cccbb7c27f1730b581f 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -768,34 +768,6 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload,
}
EXPORT_SYMBOL(mipi_dsi_generic_write);
-/**
- * mipi_dsi_generic_write_chatty() - mipi_dsi_generic_write() w/ an error log
- * @dsi: DSI peripheral device
- * @payload: buffer containing the payload
- * @size: size of payload buffer
- *
- * Like mipi_dsi_generic_write() but includes a dev_err()
- * call for you and returns 0 upon success, not the number of bytes sent.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,
- const void *payload, size_t size)
-{
- struct device *dev = &dsi->dev;
- ssize_t ret;
-
- ret = mipi_dsi_generic_write(dsi, payload, size);
- if (ret < 0) {
- dev_err(dev, "sending generic data %*ph failed: %zd\n",
- (int)size, payload, ret);
- return ret;
- }
-
- return 0;
-}
-EXPORT_SYMBOL(mipi_dsi_generic_write_chatty);
-
/**
* mipi_dsi_generic_write_multi() - mipi_dsi_generic_write_chatty() w/ accum_err
* @ctx: Context for multiple DSI transactions
@@ -912,34 +884,6 @@ ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi,
}
EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer);
-/**
- * mipi_dsi_dcs_write_buffer_chatty - mipi_dsi_dcs_write_buffer() w/ an error log
- * @dsi: DSI peripheral device
- * @data: buffer containing data to be transmitted
- * @len: size of transmission buffer
- *
- * Like mipi_dsi_dcs_write_buffer() but includes a dev_err()
- * call for you and returns 0 upon success, not the number of bytes sent.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
- const void *data, size_t len)
-{
- struct device *dev = &dsi->dev;
- ssize_t ret;
-
- ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
- if (ret < 0) {
- dev_err(dev, "sending dcs data %*ph failed: %zd\n",
- (int)len, data, ret);
- return ret;
- }
-
- return 0;
-}
-EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_chatty);
-
/**
* mipi_dsi_dcs_write_buffer_multi - mipi_dsi_dcs_write_buffer_chatty() w/ accum_err
* @ctx: Context for multiple DSI transactions
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
index 94400a78031f1b5f515c4a1519f604c0df7f3e0c..8d191d211f4fc67b8f8760571091885a1924310c 100644
--- a/include/drm/drm_mipi_dsi.h
+++ b/include/drm/drm_mipi_dsi.h
@@ -287,8 +287,6 @@ void mipi_dsi_picture_parameter_set_multi(struct mipi_dsi_multi_context *ctx,
ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload,
size_t size);
-int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,
- const void *payload, size_t size);
void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,
const void *payload, size_t size);
ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
@@ -326,8 +324,6 @@ enum mipi_dsi_dcs_tear_mode {
ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi,
const void *data, size_t len);
-int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
- const void *data, size_t len);
void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
const void *data, size_t len);
ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd,
@@ -380,27 +376,6 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,
void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx,
u16 scanline);
-/**
- * mipi_dsi_generic_write_seq - transmit data using a generic write packet
- *
- * This macro will print errors for you and will RETURN FROM THE CALLING
- * FUNCTION (yes this is non-intuitive) upon error.
- *
- * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED.
- * Please replace calls of it with mipi_dsi_generic_write_seq_multi().
- *
- * @dsi: DSI peripheral device
- * @seq: buffer containing the payload
- */
-#define mipi_dsi_generic_write_seq(dsi, seq...) \
- do { \
- static const u8 d[] = { seq }; \
- int ret; \
- ret = mipi_dsi_generic_write_chatty(dsi, d, ARRAY_SIZE(d)); \
- if (ret < 0) \
- return ret; \
- } while (0)
-
/**
* mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet
*
@@ -416,28 +391,6 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx,
mipi_dsi_generic_write_multi(ctx, d, ARRAY_SIZE(d)); \
} while (0)
-/**
- * mipi_dsi_dcs_write_seq - transmit a DCS command with payload
- *
- * This macro will print errors for you and will RETURN FROM THE CALLING
- * FUNCTION (yes this is non-intuitive) upon error.
- *
- * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED.
- * Please replace calls of it with mipi_dsi_dcs_write_seq_multi().
- *
- * @dsi: DSI peripheral device
- * @cmd: Command
- * @seq: buffer containing data to be transmitted
- */
-#define mipi_dsi_dcs_write_seq(dsi, cmd, seq...) \
- do { \
- static const u8 d[] = { cmd, seq }; \
- int ret; \
- ret = mipi_dsi_dcs_write_buffer_chatty(dsi, d, ARRAY_SIZE(d)); \
- if (ret < 0) \
- return ret; \
- } while (0)
-
/**
* mipi_dsi_dcs_write_seq_multi - transmit a DCS command with payload
*
--
2.47.0
next prev parent reply other threads:[~2025-02-13 20:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:44 [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 01/20] drm/panel/xpp055c272: Move to using mipi_dsi_*_multi() variants Anusha Srivatsa
2025-02-13 21:06 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 02/20] drm/panel/visionox-r66451: " Anusha Srivatsa
2025-02-13 21:07 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 03/20] drm/panel/asus-tm5p5-n35596: " Anusha Srivatsa
2025-02-13 21:08 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 04/20] drm/panel/boe-bf060y8m-aj0: " Anusha Srivatsa
2025-02-13 21:27 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 05/20] drm/panel/dsi-cm: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 06/20] drm/panel/sony-nt35521: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 07/20] drm/panel/ebbg-ft8719: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 08/20] drm/panel/himax-hx8394: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 09/20] drm/panel/jdi-lpm102a188a: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 10/20] drm/panel/jdi-lt070me05000: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 11/20] drm/panel/novatek-nt36523: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 12/20] drm/panel/raydium-rm67191: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 13/20] drm/panel/samsung-s6d7aa0:Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 14/20] drm/panel/s6e88a0-ams452ef01: Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 15/20] drm/panel/samsung-sofef00: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 16/20] drm/panel/ls043t1le01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 17/20] drm/panel/ls060t1sx01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 18/20] drm/panel/sony-td4353-jdi: " Anusha Srivatsa
2025-02-13 20:44 ` Anusha Srivatsa [this message]
2025-02-13 20:44 ` [PATCH 20/20] Documentation: Update the documentation Anusha Srivatsa
2025-02-14 16:26 ` [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Doug Anderson
2025-02-18 9:55 ` Maxime Ripard
2025-02-18 12:14 ` Dmitry Baryshkov
2025-02-18 15:52 ` Maxime Ripard
2025-02-19 9:11 ` Dmitry Baryshkov
2025-02-19 13:35 ` Maxime Ripard
2025-02-24 18:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213-mipi_cocci_multi-v1-19-67d94ff319cc@redhat.com \
--to=asrivats@redhat.com \
--cc=airlied@gmail.com \
--cc=aweber.kernel@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jo@jsfamily.in \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=megi@xff.cz \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robert.chiras@nxp.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®