From: Anusha Srivatsa <asrivats@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Joel Selvaraj <jo@jsfamily.in>,
Ondrej Jirman <megi@xff.cz>,
Javier Martinez Canillas <javierm@redhat.com>,
Jianhua Lu <lujianhua000@gmail.com>,
Robert Chiras <robert.chiras@nxp.com>,
Artur Weber <aweber.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Anusha Srivatsa <asrivats@redhat.com>
Subject: [PATCH 05/20] drm/panel/dsi-cm: Move to using mipi_dsi_*_multi() variants
Date: Thu, 13 Feb 2025 15:44:22 -0500 [thread overview]
Message-ID: <20250213-mipi_cocci_multi-v1-5-67d94ff319cc@redhat.com> (raw)
In-Reply-To: <20250213-mipi_cocci_multi-v1-0-67d94ff319cc@redhat.com>
Stop using deprecated API.
Used Coccinelle to make the change.
@rule_3@
identifier dsi_var;
identifier r;
identifier func;
type t;
position p;
expression dsi_device;
expression list es;
@@
t func(...) {
...
struct mipi_dsi_device *dsi_var = dsi_device;
+struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi_var };
<+...
(
-mipi_dsi_dcs_write_seq(dsi_var,es);
+mipi_dsi_dcs_write_seq_multi(&dsi_ctx,es);
|
-r = mipi_dsi_dcs_exit_sleep_mode(dsi_var)@p;
+mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
|
-r = mipi_dsi_dcs_enter_sleep_mode(dsi_var)@p;
+mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
|
-r = mipi_dsi_dcs_set_display_off(dsi_var)@p;
+mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
|
.....//rest of the mipi APIs with _multi variant
)
<+...
-if(r < 0) {
-...
-}
...+>
}
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
---
drivers/gpu/drm/panel/panel-dsi-cm.c | 44 +++++++++++++++---------------------
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c
index 6b3f4d664d2ade668525660394cf81924436492e..420a2c017354584ae75ce43fe5c5def528f1883e 100644
--- a/drivers/gpu/drm/panel/panel-dsi-cm.c
+++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
@@ -115,18 +115,18 @@ static int dsicm_dcs_read_1(struct panel_drv_data *ddata, u8 dcs_cmd, u8 *data)
static int dsicm_dcs_write_1(struct panel_drv_data *ddata, u8 dcs_cmd, u8 param)
{
return mipi_dsi_dcs_write(ddata->dsi, dcs_cmd, ¶m, 1);
+
}
static int dsicm_sleep_in(struct panel_drv_data *ddata)
{
- int r;
+ struct mipi_dsi_device *dsi = ddata->dsi;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
hw_guard_wait(ddata);
- r = mipi_dsi_dcs_enter_sleep_mode(ddata->dsi);
- if (r)
- return r;
+ mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
hw_guard_start(ddata, 120);
@@ -137,13 +137,12 @@ static int dsicm_sleep_in(struct panel_drv_data *ddata)
static int dsicm_sleep_out(struct panel_drv_data *ddata)
{
- int r;
+ struct mipi_dsi_device *dsi = ddata->dsi;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
hw_guard_wait(ddata);
- r = mipi_dsi_dcs_exit_sleep_mode(ddata->dsi);
- if (r)
- return r;
+ mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
hw_guard_start(ddata, 120);
@@ -172,15 +171,12 @@ static int dsicm_get_id(struct panel_drv_data *ddata, u8 *id1, u8 *id2, u8 *id3)
static int dsicm_set_update_window(struct panel_drv_data *ddata)
{
struct mipi_dsi_device *dsi = ddata->dsi;
- int r;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
- r = mipi_dsi_dcs_set_column_address(dsi, 0, ddata->mode.hdisplay - 1);
- if (r < 0)
- return r;
+ mipi_dsi_dcs_set_column_address_multi(&dsi_ctx, 0,
+ ddata->mode.hdisplay - 1);
- r = mipi_dsi_dcs_set_page_address(dsi, 0, ddata->mode.vdisplay - 1);
- if (r < 0)
- return r;
+ mipi_dsi_dcs_set_page_address_multi(&dsi_ctx, 0, ddata->mode.vdisplay - 1);
return 0;
}
@@ -282,6 +278,8 @@ static void dsicm_hw_reset(struct panel_drv_data *ddata)
static int dsicm_power_on(struct panel_drv_data *ddata)
{
+ struct mipi_dsi_device *dsi = ddata->dsi;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
u8 id1, id2, id3;
int r;
@@ -306,23 +304,16 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
if (r)
goto err;
- r = mipi_dsi_dcs_set_pixel_format(ddata->dsi, MIPI_DCS_PIXEL_FMT_24BIT);
- if (r)
- goto err;
+ mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx, MIPI_DCS_PIXEL_FMT_24BIT);
r = dsicm_set_update_window(ddata);
if (r)
goto err;
- r = mipi_dsi_dcs_set_display_on(ddata->dsi);
- if (r)
- goto err;
+ mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
- if (ddata->panel_data->te_support) {
- r = mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
- if (r)
- goto err;
- }
+ if (ddata->panel_data->te_support)
+ mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
/* possible panel bug */
msleep(100);
@@ -353,6 +344,7 @@ static int dsicm_power_off(struct panel_drv_data *ddata)
ddata->enabled = false;
r = mipi_dsi_dcs_set_display_off(ddata->dsi);
+
if (!r)
r = dsicm_sleep_in(ddata);
--
2.47.0
next prev parent reply other threads:[~2025-02-13 20:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:44 [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 01/20] drm/panel/xpp055c272: Move to using mipi_dsi_*_multi() variants Anusha Srivatsa
2025-02-13 21:06 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 02/20] drm/panel/visionox-r66451: " Anusha Srivatsa
2025-02-13 21:07 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 03/20] drm/panel/asus-tm5p5-n35596: " Anusha Srivatsa
2025-02-13 21:08 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 04/20] drm/panel/boe-bf060y8m-aj0: " Anusha Srivatsa
2025-02-13 21:27 ` Dmitry Baryshkov
2025-02-13 20:44 ` Anusha Srivatsa [this message]
2025-02-13 20:44 ` [PATCH 06/20] drm/panel/sony-nt35521: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 07/20] drm/panel/ebbg-ft8719: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 08/20] drm/panel/himax-hx8394: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 09/20] drm/panel/jdi-lpm102a188a: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 10/20] drm/panel/jdi-lt070me05000: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 11/20] drm/panel/novatek-nt36523: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 12/20] drm/panel/raydium-rm67191: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 13/20] drm/panel/samsung-s6d7aa0:Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 14/20] drm/panel/s6e88a0-ams452ef01: Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 15/20] drm/panel/samsung-sofef00: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 16/20] drm/panel/ls043t1le01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 17/20] drm/panel/ls060t1sx01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 18/20] drm/panel/sony-td4353-jdi: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 19/20] drm/panel: Remove deprecated functions Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 20/20] Documentation: Update the documentation Anusha Srivatsa
2025-02-14 16:26 ` [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Doug Anderson
2025-02-18 9:55 ` Maxime Ripard
2025-02-18 12:14 ` Dmitry Baryshkov
2025-02-18 15:52 ` Maxime Ripard
2025-02-19 9:11 ` Dmitry Baryshkov
2025-02-19 13:35 ` Maxime Ripard
2025-02-24 18:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213-mipi_cocci_multi-v1-5-67d94ff319cc@redhat.com \
--to=asrivats@redhat.com \
--cc=airlied@gmail.com \
--cc=aweber.kernel@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jo@jsfamily.in \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=megi@xff.cz \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robert.chiras@nxp.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®