From: Tang Yizhou <yizhou.tang@shopee.com>
To: yukuai1@huaweicloud.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Tang Yizhou <yizhou.tang@shopee.com>
Subject: [PATCH v2 1/2] blk-wbt: Fix some comments
Date: Thu, 13 Feb 2025 18:06:10 +0800 [thread overview]
Message-ID: <20250213100611.209997-2-yizhou.tang@shopee.com> (raw)
In-Reply-To: <20250213100611.209997-1-yizhou.tang@shopee.com>
From: Tang Yizhou <yizhou.tang@shopee.com>
wbt_wait() no longer uses a spinlock as a parameter. Update the function
comments accordingly.
RWB_UNKNOWN_BUMP is used when we gradually adjust scale_steps toward the
center state, which is a value of 0.
Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
---
block/blk-wbt.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 6dfc659d22e2..8b73c0c11aec 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -136,8 +136,9 @@ enum {
RWB_MIN_WRITE_SAMPLES = 3,
/*
- * If we have this number of consecutive windows with not enough
- * information to scale up or down, scale up.
+ * If we have this number of consecutive windows without enough
+ * information to scale up or down, slowly return to center state
+ * (step == 0).
*/
RWB_UNKNOWN_BUMP = 5,
};
@@ -638,11 +639,7 @@ static void wbt_cleanup(struct rq_qos *rqos, struct bio *bio)
__wbt_done(rqos, flags);
}
-/*
- * May sleep, if we have exceeded the writeback limits. Caller can pass
- * in an irq held spinlock, if it holds one when calling this function.
- * If we do sleep, we'll release and re-grab it.
- */
+/* May sleep, if we have exceeded the writeback limits. */
static void wbt_wait(struct rq_qos *rqos, struct bio *bio)
{
struct rq_wb *rwb = RQWB(rqos);
--
2.25.1
next prev parent reply other threads:[~2025-02-13 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 10:06 [PATCH v2 0/2] Fix and cleanup some comments in blk-wbt Tang Yizhou
2025-02-13 10:06 ` Tang Yizhou [this message]
2025-02-13 11:04 ` [PATCH v2 1/2] blk-wbt: Fix some comments Yu Kuai
2025-02-25 12:38 ` Yizhou Tang
2025-02-13 10:06 ` [PATCH v2 2/2] blk-wbt: Cleanup a comment in wb_timer_fn Tang Yizhou
2025-02-13 11:16 ` Yu Kuai
2025-02-13 14:28 ` Tang Yizhou
2025-02-25 15:44 ` [PATCH v2 0/2] Fix and cleanup some comments in blk-wbt Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213100611.209997-2-yizhou.tang@shopee.com \
--to=yizhou.tang@shopee.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®