From: Yu Kuai <yukuai1@huaweicloud.com>
To: Tang Yizhou <yizhou.tang@shopee.com>,
yukuai1@huaweicloud.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2 2/2] blk-wbt: Cleanup a comment in wb_timer_fn
Date: Thu, 13 Feb 2025 19:16:41 +0800 [thread overview]
Message-ID: <70741bf4-1d1f-e017-7c76-8b7e3b1d9203@huaweicloud.com> (raw)
In-Reply-To: <20250213100611.209997-3-yizhou.tang@shopee.com>
Hi,
在 2025/02/13 18:06, Tang Yizhou 写道:
> From: Tang Yizhou <yizhou.tang@shopee.com>
>
> The original comment contains a grammatical error. Rewrite it into a more
> easily understandable sentence.
>
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
> ---
> block/blk-wbt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Personally, I don't think this patch is necessary, people can still
understand with this error. I'm not expecting a seperate patch :(
Thanks,
Kuai
> diff --git a/block/blk-wbt.c b/block/blk-wbt.c
> index 8b73c0c11aec..f1754d07f7e0 100644
> --- a/block/blk-wbt.c
> +++ b/block/blk-wbt.c
> @@ -447,9 +447,9 @@ static void wb_timer_fn(struct blk_stat_callback *cb)
> break;
> case LAT_UNKNOWN_WRITES:
> /*
> - * We started a the center step, but don't have a valid
> - * read/write sample, but we do have writes going on.
> - * Allow step to go negative, to increase write perf.
> + * We don't have a valid read/write sample, but we do have
> + * writes going on. Allow step to go negative, to increase
> + * write performance.
> */
> scale_up(rwb);
> break;
>
next prev parent reply other threads:[~2025-02-13 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 10:06 [PATCH v2 0/2] Fix and cleanup some comments in blk-wbt Tang Yizhou
2025-02-13 10:06 ` [PATCH v2 1/2] blk-wbt: Fix some comments Tang Yizhou
2025-02-13 11:04 ` Yu Kuai
2025-02-25 12:38 ` Yizhou Tang
2025-02-13 10:06 ` [PATCH v2 2/2] blk-wbt: Cleanup a comment in wb_timer_fn Tang Yizhou
2025-02-13 11:16 ` Yu Kuai [this message]
2025-02-13 14:28 ` Tang Yizhou
2025-02-25 15:44 ` [PATCH v2 0/2] Fix and cleanup some comments in blk-wbt Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70741bf4-1d1f-e017-7c76-8b7e3b1d9203@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yizhou.tang@shopee.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®