* [PATCH] media: i2c: imx219: remove context around case
@ 2025-02-20 14:06 Cosmin Tanislav
2025-02-20 17:14 ` Dave Stevenson
0 siblings, 1 reply; 2+ messages in thread
From: Cosmin Tanislav @ 2025-02-20 14:06 UTC (permalink / raw)
Cc: Dave Stevenson, Sakari Ailus, Mauro Carvalho Chehab, linux-media,
linux-kernel, Cosmin Tanislav
There are no longer variable declarations here, the context is useless.
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
---
drivers/media/i2c/imx219.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index f662c9d755114..fcd98ee54768e 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -947,10 +947,9 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
struct v4l2_subdev_selection *sel)
{
switch (sel->target) {
- case V4L2_SEL_TGT_CROP: {
+ case V4L2_SEL_TGT_CROP:
sel->r = *v4l2_subdev_state_get_crop(state, 0);
return 0;
- }
case V4L2_SEL_TGT_NATIVE_SIZE:
sel->r.top = 0;
--
2.48.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: i2c: imx219: remove context around case
2025-02-20 14:06 [PATCH] media: i2c: imx219: remove context around case Cosmin Tanislav
@ 2025-02-20 17:14 ` Dave Stevenson
0 siblings, 0 replies; 2+ messages in thread
From: Dave Stevenson @ 2025-02-20 17:14 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: Sakari Ailus, Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Cosmin
Thanks for the patch.
On Thu, 20 Feb 2025 at 14:06, Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> There are no longer variable declarations here, the context is useless.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> drivers/media/i2c/imx219.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index f662c9d755114..fcd98ee54768e 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -947,10 +947,9 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
> struct v4l2_subdev_selection *sel)
> {
> switch (sel->target) {
> - case V4L2_SEL_TGT_CROP: {
> + case V4L2_SEL_TGT_CROP:
> sel->r = *v4l2_subdev_state_get_crop(state, 0);
> return 0;
> - }
>
> case V4L2_SEL_TGT_NATIVE_SIZE:
> sel->r.top = 0;
> --
> 2.48.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-20 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-20 14:06 [PATCH] media: i2c: imx219: remove context around case Cosmin Tanislav
2025-02-20 17:14 ` Dave Stevenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®