* [PATCH -next] drm: adp: Remove unnecessary print function dev_err()
@ 2025-03-05 2:05 Jiapeng Chong
2025-03-05 8:17 ` Sasha Finkelstein
2025-03-05 13:43 ` Alyssa Rosenzweig
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2025-03-05 2:05 UTC (permalink / raw)
To: fnkl.kernel
Cc: j, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, asahi, linux-kernel, Jiapeng Chong, Abaci Robot
The print function dev_err() is redundant because platform_get_irq_byname()
already prints an error.
./drivers/gpu/drm/adp/adp_drv.c:470:2-9: line 470 is redundant because platform_get_irq() already prints an error.
./drivers/gpu/drm/adp/adp_drv.c:476:2-9: line 476 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19211
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/adp/adp_drv.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c
index 0a39abdc9238..0eeb9e5fab26 100644
--- a/drivers/gpu/drm/adp/adp_drv.c
+++ b/drivers/gpu/drm/adp/adp_drv.c
@@ -466,16 +466,12 @@ static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *ad
}
adp->be_irq = platform_get_irq_byname(pdev, "be");
- if (adp->be_irq < 0) {
- dev_err(dev, "failed to find be irq");
+ if (adp->be_irq < 0)
return adp->be_irq;
- }
adp->fe_irq = platform_get_irq_byname(pdev, "fe");
- if (adp->fe_irq < 0) {
- dev_err(dev, "failed to find fe irq");
+ if (adp->fe_irq < 0)
return adp->fe_irq;
- }
return 0;
}
--
2.32.0.3.g01195cf9f
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm: adp: Remove unnecessary print function dev_err()
2025-03-05 2:05 [PATCH -next] drm: adp: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2025-03-05 8:17 ` Sasha Finkelstein
2025-03-05 13:43 ` Alyssa Rosenzweig
1 sibling, 0 replies; 3+ messages in thread
From: Sasha Finkelstein @ 2025-03-05 8:17 UTC (permalink / raw)
To: Jiapeng Chong
Cc: j, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, asahi, linux-kernel, Abaci Robot
On Wed, 5 Mar 2025 at 03:06, Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The print function dev_err() is redundant because platform_get_irq_byname()
> already prints an error.
Acked-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm: adp: Remove unnecessary print function dev_err()
2025-03-05 2:05 [PATCH -next] drm: adp: Remove unnecessary print function dev_err() Jiapeng Chong
2025-03-05 8:17 ` Sasha Finkelstein
@ 2025-03-05 13:43 ` Alyssa Rosenzweig
1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Rosenzweig @ 2025-03-05 13:43 UTC (permalink / raw)
To: fnkl.kernel, Jiapeng Chong
Cc: j, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, asahi, linux-kernel, Abaci Robot
On Wed, 05 Mar 2025 10:05:46 +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq_byname()
> already prints an error.
>
> ./drivers/gpu/drm/adp/adp_drv.c:470:2-9: line 470 is redundant because platform_get_irq() already prints an error.
> ./drivers/gpu/drm/adp/adp_drv.c:476:2-9: line 476 is redundant because platform_get_irq() already prints an error.
>
>
> [...]
Applied, thanks!
[1/1] drm: adp: Remove unnecessary print function dev_err()
commit: e4c0fd3f965533cd2b38200ca73625afd602d39b
Best regards,
--
Alyssa Rosenzweig <alyssa@rosenzweig.io>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-05 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-05 2:05 [PATCH -next] drm: adp: Remove unnecessary print function dev_err() Jiapeng Chong
2025-03-05 8:17 ` Sasha Finkelstein
2025-03-05 13:43 ` Alyssa Rosenzweig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®