* Re: [PATCH] firmware: thead: add CONFIG_MAILBOX dependency
2025-03-14 15:48 ` [PATCH] firmware: thead: add CONFIG_MAILBOX dependency Arnd Bergmann
@ 2025-03-14 16:39 ` Michal Wilczynski
2025-03-18 12:14 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Michal Wilczynski @ 2025-03-14 16:39 UTC (permalink / raw)
To: Arnd Bergmann, Ulf Hansson, Drew Fustini
Cc: Arnd Bergmann, Guillaume La Roque, Krzysztof Kozlowski,
Tudor Ambarus, Prasad Pandit, linux-kernel
On 3/14/25 16:48, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, the driver fails to build:
>
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_call_rpc':
> thead,th1520-aon.c:(.text+0x28): undefined reference to `mbox_send_message'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_deinit':
> thead,th1520-aon.c:(.text+0x17e): undefined reference to `mbox_free_channel'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_init':
> thead,th1520-aon.c:(.text+0x1d9): undefined reference to `mbox_request_channel_byname'
>
> Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/firmware/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 42e3dd1c387a..6ab9f7ca7ff1 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -239,6 +239,7 @@ config SYSFB_SIMPLEFB
> config TH1520_AON_PROTOCOL
> tristate "Always-On firmware protocol"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on MAILBOX
> help
> Power, clock, and resource management capabilities on the TH1520 SoC are
> managed by the E902 core. Firmware running on this core communicates with
Thanks, looks good shouldn't have missed that.
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] firmware: thead: add CONFIG_MAILBOX dependency
2025-03-14 15:48 ` [PATCH] firmware: thead: add CONFIG_MAILBOX dependency Arnd Bergmann
2025-03-14 16:39 ` Michal Wilczynski
@ 2025-03-18 12:14 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-03-18 12:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Drew Fustini, Michal Wilczynski, Arnd Bergmann,
Guillaume La Roque, Krzysztof Kozlowski, Tudor Ambarus,
Prasad Pandit, linux-kernel
On Fri, 14 Mar 2025 at 16:48, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, the driver fails to build:
>
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_call_rpc':
> thead,th1520-aon.c:(.text+0x28): undefined reference to `mbox_send_message'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_deinit':
> thead,th1520-aon.c:(.text+0x17e): undefined reference to `mbox_free_channel'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_init':
> thead,th1520-aon.c:(.text+0x1d9): undefined reference to `mbox_request_channel_byname'
>
> Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/firmware/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 42e3dd1c387a..6ab9f7ca7ff1 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -239,6 +239,7 @@ config SYSFB_SIMPLEFB
> config TH1520_AON_PROTOCOL
> tristate "Always-On firmware protocol"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on MAILBOX
> help
> Power, clock, and resource management capabilities on the TH1520 SoC are
> managed by the E902 core. Firmware running on this core communicates with
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread