From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <linma@zju.edu.cn>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<gnaaman@drivenets.com>, <horms@kernel.org>,
<joel.granados@kernel.org>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<lizetao1@huawei.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH net] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES
Date: Fri, 14 Mar 2025 12:34:44 -0700 [thread overview]
Message-ID: <20250314193445.26852-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250314155237.81071-1-linma@zju.edu.cn>
From: Lin Ma <linma@zju.edu.cn>
Date: Fri, 14 Mar 2025 23:52:37 +0800
> Previous commit 8b5c171bb3dc ("neigh: new unresolved queue limits")
> introduces new netlink attribute NDTPA_QUEUE_LENBYTES to represent
> approximative value for deprecated QUEUE_LEN. However, it forgot to add
> the associated nla_policy in nl_ntbl_parm_policy array. Fix it with one
> simple NLA_U32 type policy.
>
> Fixes: 8b5c171bb3dc ("neigh: new unresolved queue limits")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
> ---
> net/core/neighbour.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index bd0251bd74a1..b4f89fbb59df 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -2250,6 +2250,7 @@ static const struct nla_policy nl_neightbl_policy[NDTA_MAX+1] = {
> static const struct nla_policy nl_ntbl_parm_policy[NDTPA_MAX+1] = {
> [NDTPA_IFINDEX] = { .type = NLA_U32 },
> [NDTPA_QUEUE_LEN] = { .type = NLA_U32 },
> + [NDTPA_QUEUE_LENBYTES] = { .type = NLA_U32 },
Please keep this line alinged with other lines; add one more tab
before '='.
> [NDTPA_PROXY_QLEN] = { .type = NLA_U32 },
> [NDTPA_APP_PROBES] = { .type = NLA_U32 },
> [NDTPA_UCAST_PROBES] = { .type = NLA_U32 },
> --
> 2.39.0
prev parent reply other threads:[~2025-03-14 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 15:52 Lin Ma
2025-03-14 19:34 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314193445.26852-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnaaman@drivenets.com \
--cc=horms@kernel.org \
--cc=joel.granados@kernel.org \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®