mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES
@ 2025-03-14 15:52 Lin Ma
  2025-03-14 19:34 ` Kuniyuki Iwashima
  0 siblings, 1 reply; 2+ messages in thread
From: Lin Ma @ 2025-03-14 15:52 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, horms, kuniyu, gnaaman,
	joel.granados, lizetao1, netdev, linux-kernel
  Cc: Lin Ma

Previous commit 8b5c171bb3dc ("neigh: new unresolved queue limits")
introduces new netlink attribute NDTPA_QUEUE_LENBYTES to represent
approximative value for deprecated QUEUE_LEN. However, it forgot to add
the associated nla_policy in nl_ntbl_parm_policy array. Fix it with one
simple NLA_U32 type policy.

Fixes: 8b5c171bb3dc ("neigh: new unresolved queue limits")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
---
 net/core/neighbour.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index bd0251bd74a1..b4f89fbb59df 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2250,6 +2250,7 @@ static const struct nla_policy nl_neightbl_policy[NDTA_MAX+1] = {
 static const struct nla_policy nl_ntbl_parm_policy[NDTPA_MAX+1] = {
 	[NDTPA_IFINDEX]			= { .type = NLA_U32 },
 	[NDTPA_QUEUE_LEN]		= { .type = NLA_U32 },
+	[NDTPA_QUEUE_LENBYTES]	= { .type = NLA_U32 },
 	[NDTPA_PROXY_QLEN]		= { .type = NLA_U32 },
 	[NDTPA_APP_PROBES]		= { .type = NLA_U32 },
 	[NDTPA_UCAST_PROBES]		= { .type = NLA_U32 },
-- 
2.39.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES
  2025-03-14 15:52 [PATCH net] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES Lin Ma
@ 2025-03-14 19:34 ` Kuniyuki Iwashima
  0 siblings, 0 replies; 2+ messages in thread
From: Kuniyuki Iwashima @ 2025-03-14 19:34 UTC (permalink / raw)
  To: linma
  Cc: davem, edumazet, gnaaman, horms, joel.granados, kuba, kuniyu,
	linux-kernel, lizetao1, netdev, pabeni

From: Lin Ma <linma@zju.edu.cn>
Date: Fri, 14 Mar 2025 23:52:37 +0800
> Previous commit 8b5c171bb3dc ("neigh: new unresolved queue limits")
> introduces new netlink attribute NDTPA_QUEUE_LENBYTES to represent
> approximative value for deprecated QUEUE_LEN. However, it forgot to add
> the associated nla_policy in nl_ntbl_parm_policy array. Fix it with one
> simple NLA_U32 type policy.
> 
> Fixes: 8b5c171bb3dc ("neigh: new unresolved queue limits")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
> ---
>  net/core/neighbour.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index bd0251bd74a1..b4f89fbb59df 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -2250,6 +2250,7 @@ static const struct nla_policy nl_neightbl_policy[NDTA_MAX+1] = {
>  static const struct nla_policy nl_ntbl_parm_policy[NDTPA_MAX+1] = {
>  	[NDTPA_IFINDEX]			= { .type = NLA_U32 },
>  	[NDTPA_QUEUE_LEN]		= { .type = NLA_U32 },
> +	[NDTPA_QUEUE_LENBYTES]	= { .type = NLA_U32 },

Please keep this line alinged with other lines; add one more tab
before '='.


>  	[NDTPA_PROXY_QLEN]		= { .type = NLA_U32 },
>  	[NDTPA_APP_PROBES]		= { .type = NLA_U32 },
>  	[NDTPA_UCAST_PROBES]		= { .type = NLA_U32 },
> -- 
> 2.39.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-14 19:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-14 15:52 [PATCH net] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES Lin Ma
2025-03-14 19:34 ` Kuniyuki Iwashima

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®