mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Beleswar Padhi <b-padhi@ti.com>
To: <andersson@kernel.org>, <mathieu.poirier@linaro.org>
Cc: <afd@ti.com>, <hnagalla@ti.com>, <u-kumar1@ti.com>, <jm@ti.com>,
	<jan.kiszka@siemens.com>, <christophe.jaillet@wanadoo.fr>,
	<jkangas@redhat.com>, <eballetbo@redhat.com>, <b-padhi@ti.com>,
	<linux-remoteproc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v9 06/26] remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick}
Date: Mon, 17 Mar 2025 17:36:02 +0530	[thread overview]
Message-ID: <20250317120622.1746415-7-b-padhi@ti.com> (raw)
In-Reply-To: <20250317120622.1746415-1-b-padhi@ti.com>

From: Siddharth Vadapalli <s-vadapalli@ti.com>

Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during
probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()"
and "k3_r5_rproc_kick()" callbacks, causing them to exit if the remote
core's state is "RPROC_DETACHED". However, the "__rproc_attach()"
function that is responsible for attaching to a remote core, updates
the state of the remote core to "RPROC_ATTACHED" only after invoking
"rproc_start_subdevices()".

The "rproc_start_subdevices()" function triggers the probe of the Virtio
RPMsg devices associated with the remote core, which require that the
"k3_r5_rproc_kick()" and "k3_r5_rproc_mbox_callback()" callbacks are
functional. Hence, drop the check in the callbacks.

Fixes: f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 drivers/remoteproc/ti_k3_r5_remoteproc.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
index 29205d9e21af..c0e4da82775d 100644
--- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
@@ -224,10 +224,6 @@ static void k3_r5_rproc_mbox_callback(struct mbox_client *client, void *data)
 	const char *name = kproc->rproc->name;
 	u32 msg = omap_mbox_message(data);
 
-	/* Do not forward message from a detached core */
-	if (kproc->rproc->state == RPROC_DETACHED)
-		return;
-
 	dev_dbg(dev, "mbox msg: 0x%x\n", msg);
 
 	switch (msg) {
@@ -263,10 +259,6 @@ static void k3_r5_rproc_kick(struct rproc *rproc, int vqid)
 	mbox_msg_t msg = (mbox_msg_t)vqid;
 	int ret;
 
-	/* Do not forward message to a detached core */
-	if (kproc->rproc->state == RPROC_DETACHED)
-		return;
-
 	/* send the index of the triggered virtqueue in the mailbox payload */
 	ret = mbox_send_message(kproc->mbox, (void *)msg);
 	if (ret < 0)
-- 
2.34.1


  parent reply	other threads:[~2025-03-17 12:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 12:05 [PATCH v9 00/26] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers Beleswar Padhi
2025-03-17 12:05 ` [PATCH v9 01/26] remoteproc: k3-r5: Re-order internal memory initialization function Beleswar Padhi
2025-04-07 13:29   ` Andrew Davis
2025-04-08  8:14     ` Beleswar Prasad Padhi
2025-03-17 12:05 ` [PATCH v9 02/26] remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4 Beleswar Padhi
2025-04-07 13:33   ` Andrew Davis
2025-04-08  8:28     ` Beleswar Prasad Padhi
2025-03-17 12:05 ` [PATCH v9 03/26] remoteproc: k3-r5: Use k3_r5_rproc_mem_data structure for memory info Beleswar Padhi
2025-04-07 13:37   ` Andrew Davis
2025-03-17 12:06 ` [PATCH v9 04/26] remoteproc: k3-{m4/dsp}: Align internal rproc data structure with R5 Beleswar Padhi
2025-04-07 13:40   ` Andrew Davis
2025-03-17 12:06 ` [PATCH v9 05/26] remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info Beleswar Padhi
2025-04-07 13:43   ` Andrew Davis
2025-04-08  8:38     ` Beleswar Prasad Padhi
2025-03-17 12:06 ` Beleswar Padhi [this message]
2025-04-07 13:25   ` [PATCH v9 06/26] remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick} Andrew Davis
2025-03-17 12:06 ` [PATCH v9 07/26] remoteproc: k3-dsp: Drop check performed in k3_dsp_rproc_{mbox_callback/kick} Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 08/26] remoteproc: k3-r5: Refactor sequential core power up/down operations Beleswar Padhi
2025-04-07 13:45   ` Andrew Davis
2025-04-08  8:41     ` Beleswar Prasad Padhi
2025-03-17 12:06 ` [PATCH v9 09/26] remoteproc: k3: Refactor shared data structures Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 10/26] remoteproc: k3: Refactor mailbox rx_callback functions into common driver Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 11/26] remoteproc: k3: Refactor .kick rproc ops " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 12/26] remoteproc: k3: Refactor rproc_reset() implementation " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 13/26] remoteproc: k3: Refactor rproc_release() " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 14/26] remoteproc: k3: Refactor rproc_request_mbox() implementations " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 15/26] remoteproc: k3: Refactor .prepare rproc ops " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 16/26] remoteproc: k3: Refactor .unprepare " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 17/26] remoteproc: k3: Refactor .start " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 18/26] remoteproc: k3: Refactor .stop " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 19/26] remoteproc: k3: Refactor .attach " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 20/26] remoteproc: k3: Refactor .detach " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 21/26] remoteproc: k3: Refactor .get_loaded_rsc_table " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 22/26] remoteproc: k3: Refactor .da_to_va rproc " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 23/26] remoteproc: k3: Refactor of_get_memories() functions " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 24/26] remoteproc: k3: Refactor mem_release() " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 25/26] remoteproc: k3: Refactor reserved_mem_init() " Beleswar Padhi
2025-03-17 12:06 ` [PATCH v9 26/26] remoteproc: k3: Refactor release_tsp() " Beleswar Padhi
2025-04-07 13:04 ` [PATCH v9 00/26] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers Beleswar Prasad Padhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250317120622.1746415-7-b-padhi@ti.com \
    --to=b-padhi@ti.com \
    --cc=afd@ti.com \
    --cc=andersson@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=eballetbo@redhat.com \
    --cc=hnagalla@ti.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jkangas@redhat.com \
    --cc=jm@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®