[PATCH] dql: Fix dql->limit value when reset.

[PATCH] dql: Fix dql->limit value when reset.

[Jing Su]

Executing dql_reset after setting a non-zero value for limit_min can
lead to an unreasonable situation where dql->limit is less than
dql->limit_min.

For instance, after setting
/sys/class/net/eth*/queues/tx-0/byte_queue_limits/limit_min,
an ifconfig down/up operation might cause the ethernet driver to call
netdev_tx_reset_queue, which in turn invokes dql_reset.

In this case, dql->limit is reset to 0 while dql->limit_min remains
non-zero value, which is unexpected. The limit should always be
greater than or equal to limit_min.

Signed-off-by: Jing Su <jingsusu@didiglobal.com>
---
 lib/dynamic_queue_limits.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
index c1b7638a594a..f97a752e900a 100644
--- a/lib/dynamic_queue_limits.c
+++ b/lib/dynamic_queue_limits.c
@@ -190,7 +190,7 @@ EXPORT_SYMBOL(dql_completed);
 void dql_reset(struct dql *dql)
 {
 	/* Reset all dynamic values */
-	dql->limit = 0;
+	dql->limit = dql->min_limit;
 	dql->num_queued = 0;
 	dql->num_completed = 0;
 	dql->last_obj_cnt = 0;
-- 
2.34.1

Re: [PATCH] dql: Fix dql->limit value when reset.

[Andrew Morton]

On Tue, 18 Mar 2025 15:31:02 +0800 Jing Su <jingsusu@didiglobal.com> wrote:

>  lib/dynamic_queue_limits.c | 2 +-
>  

This belongs to the networking people.

get_maintainer is silent for some reason.  So using `git log
lib/dynamic_queue_limits.c | grep Author' suggests

Author: Eric Dumazet <edumazet@google.com>
Author: Breno Leitao <leitao@debian.org>
Author: Jakub Kicinski <kuba@kernel.org>
...
Author: David S. Miller <davem@davemloft.net>
...

Please resend to those developers and cc netdev@vger.kernel.org, thanks.