* [PATCH] ksmbd: use aead_request_free to match aead_request_alloc
@ 2025-03-18 12:12 Miaoqian Lin
2025-03-18 13:14 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-03-18 12:12 UTC (permalink / raw)
To: Namjae Jeon, Steve French, Sergey Senozhatsky, Tom Talpey,
Hyunchul Lee, Ronnie Sahlberg, linux-cifs, linux-kernel
Cc: linmq006
Use aead_request_free() instead of kfree() to properly free memory
allocated by aead_request_alloc(). This ensures sensitive crypto data
is zeroed before being freed.
Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
fs/smb/server/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/server/auth.c b/fs/smb/server/auth.c
index 2a5b4a96bf99..00b31cf86462 100644
--- a/fs/smb/server/auth.c
+++ b/fs/smb/server/auth.c
@@ -1218,7 +1218,7 @@ int ksmbd_crypt_message(struct ksmbd_work *work, struct kvec *iov,
free_sg:
kfree(sg);
free_req:
- kfree(req);
+ aead_request_free(req);
free_ctx:
ksmbd_release_crypto_ctx(ctx);
return rc;
--
2.39.5 (Apple Git-154)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ksmbd: use aead_request_free to match aead_request_alloc
2025-03-18 12:12 [PATCH] ksmbd: use aead_request_free to match aead_request_alloc Miaoqian Lin
@ 2025-03-18 13:14 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2025-03-18 13:14 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Steve French, Sergey Senozhatsky, Tom Talpey, Hyunchul Lee,
Ronnie Sahlberg, linux-cifs, linux-kernel
On Tue, Mar 18, 2025 at 9:12 PM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> Use aead_request_free() instead of kfree() to properly free memory
> allocated by aead_request_alloc(). This ensures sensitive crypto data
> is zeroed before being freed.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Applied it to #ksmbd-for-next-next.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-18 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-18 12:12 [PATCH] ksmbd: use aead_request_free to match aead_request_alloc Miaoqian Lin
2025-03-18 13:14 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®