* [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address
@ 2025-03-17 20:26 David Heidelberg via B4 Relay
2025-03-18 8:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-03-17 20:26 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Andy Gross
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
The device and driver do support setting a custom MAC address.
Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
@@ -68,6 +68,8 @@ properties:
- const: tx
- const: rx
+ local-mac-address: true
+
qcom,smem-states:
$ref: /schemas/types.yaml#/definitions/phandle-array
maxItems: 2
---
base-commit: e94bd4ec45ac156616da285a0bf03056cd7430fc
change-id: 20250317-wcnss-local-mac-57da1ca5feb9
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address
2025-03-17 20:26 [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address David Heidelberg via B4 Relay
@ 2025-03-18 8:49 ` Krzysztof Kozlowski
2025-03-18 9:07 ` David Heidelberg
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 8:49 UTC (permalink / raw)
To: David Heidelberg
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Andy Gross, linux-arm-msm, devicetree,
linux-kernel
On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
> The device and driver do support setting a custom MAC address.
>
> Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> @@ -68,6 +68,8 @@ properties:
> - const: tx
> - const: rx
>
> + local-mac-address: true
Which referenced binding provides the definition of this property (its
type)? AFAIK, that's not a property of Wifi nodes.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address
2025-03-18 8:49 ` Krzysztof Kozlowski
@ 2025-03-18 9:07 ` David Heidelberg
2025-03-18 14:26 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: David Heidelberg @ 2025-03-18 9:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Andy Gross, linux-arm-msm, devicetree,
linux-kernel
On 18/03/2025 09:49, Krzysztof Kozlowski wrote:
> On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
>> The device and driver do support setting a custom MAC address.
>>
>> Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> @@ -68,6 +68,8 @@ properties:
>> - const: tx
>> - const: rx
>>
>> + local-mac-address: true
>
> Which referenced binding provides the definition of this property (its
> type)? AFAIK, that's not a property of Wifi nodes.
Good catch!
Would you find reasonable to add the property to wireless/ieee80211.yaml ?
I feel like this could be "shared" between ethernet and ieee80211, but
have it twice in these two sounds acceptable to me.
Thanks
>
> Best regards,
> Krzysztof
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address
2025-03-18 9:07 ` David Heidelberg
@ 2025-03-18 14:26 ` Rob Herring
2025-03-18 16:00 ` David Heidelberg
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2025-03-18 14:26 UTC (permalink / raw)
To: David Heidelberg
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Conor Dooley, Andy Gross, linux-arm-msm,
devicetree, linux-kernel
On Tue, Mar 18, 2025 at 10:07:22AM +0100, David Heidelberg wrote:
> On 18/03/2025 09:49, Krzysztof Kozlowski wrote:
> > On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
> > > The device and driver do support setting a custom MAC address.
> > >
> > > Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > > Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
> > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> > > @@ -68,6 +68,8 @@ properties:
> > > - const: tx
> > > - const: rx
> > > + local-mac-address: true
> >
> > Which referenced binding provides the definition of this property (its
> > type)? AFAIK, that's not a property of Wifi nodes.
>
> Good catch!
>
> Would you find reasonable to add the property to wireless/ieee80211.yaml ?
>
> I feel like this could be "shared" between ethernet and ieee80211, but have
> it twice in these two sounds acceptable to me.
Can you pick up and finish this series[1].
Rob
[1] https://lore.kernel.org/all/20230220140201.20450889@kernel.org/#r
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address
2025-03-18 14:26 ` Rob Herring
@ 2025-03-18 16:00 ` David Heidelberg
0 siblings, 0 replies; 5+ messages in thread
From: David Heidelberg @ 2025-03-18 16:00 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Conor Dooley, Andy Gross, linux-arm-msm,
devicetree, linux-kernel
Sure, I'll respin it.
Thanks!
On 18/03/2025 15:26, Rob Herring wrote:
> On Tue, Mar 18, 2025 at 10:07:22AM +0100, David Heidelberg wrote:
>> On 18/03/2025 09:49, Krzysztof Kozlowski wrote:
>>> On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
>>>> The device and driver do support setting a custom MAC address.
>>>>
>>>> Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>> ---
>>>> Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>>>> index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
>>>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>>>> @@ -68,6 +68,8 @@ properties:
>>>> - const: tx
>>>> - const: rx
>>>> + local-mac-address: true
>>>
>>> Which referenced binding provides the definition of this property (its
>>> type)? AFAIK, that's not a property of Wifi nodes.
>>
>> Good catch!
>>
>> Would you find reasonable to add the property to wireless/ieee80211.yaml ?
>>
>> I feel like this could be "shared" between ethernet and ieee80211, but have
>> it twice in these two sounds acceptable to me.
>
> Can you pick up and finish this series[1].
>
> Rob
>
> [1] https://lore.kernel.org/all/20230220140201.20450889@kernel.org/#r
--
David Heidelberg
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-18 16:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-17 20:26 [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address David Heidelberg via B4 Relay
2025-03-18 8:49 ` Krzysztof Kozlowski
2025-03-18 9:07 ` David Heidelberg
2025-03-18 14:26 ` Rob Herring
2025-03-18 16:00 ` David Heidelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®