mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kstrtox: Add support for enabled and disabled in kstrtobool()
@ 2025-03-21  2:25 Mario Limonciello
  0 siblings, 0 replies; only message in thread
From: Mario Limonciello @ 2025-03-21  2:25 UTC (permalink / raw)
  To: mario.limonciello, Andrew Morton; +Cc: linux-kernel

From: Mario Limonciello <mario.limonciello@amd.com>

In some places in the kernel there is a design pattern for sysfs
attributes to use kstrtobool() in store() and str_enabled_disabled()
in show().

This is counterintuitive to interact with because kstrtobool() takes
on/off but str_enabled_disabled() shows enabled/disabled. Some of those
sysfs uses could switch to str_on_off() but for some attributes
enabled/disabled really makes more sense.

Add support for kstrtobool() to accept enabled/disabled.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 lib/kstrtox.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index d586e6af5e5a6..bdde40cd69d78 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -351,6 +351,8 @@ int kstrtobool(const char *s, bool *res)
 		return -EINVAL;
 
 	switch (s[0]) {
+	case 'e':
+	case 'E':
 	case 'y':
 	case 'Y':
 	case 't':
@@ -358,6 +360,8 @@ int kstrtobool(const char *s, bool *res)
 	case '1':
 		*res = true;
 		return 0;
+	case 'd':
+	case 'D':
 	case 'n':
 	case 'N':
 	case 'f':
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-21  2:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-21  2:25 [PATCH] kstrtox: Add support for enabled and disabled in kstrtobool() Mario Limonciello

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®