* [PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe()
@ 2025-03-27 3:52 shao.mingyin
2025-03-27 8:44 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: shao.mingyin @ 2025-03-27 3:52 UTC (permalink / raw)
To: laurent.pinchart
Cc: andrzej.hajda, neil.armstrong, rfoss, laurent.pinchart, jonas,
jernej.skrabec, yang.yang29, xu.xin16, ye.xingchen, linux-kernel,
zhang.enpei
From: Zhang Enpei <zhang.enpei@zte.com.cn>
Replace the open-code with dev_err_probe() to simplify the code.
Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
---
v2:
- reduce a PTR_ERR call since dev_err_probe() will add
the error value to the message
drivers/gpu/drm/bridge/thc63lvd1024.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
index bba10cf9b4f9..8f3096fa3dd7 100644
--- a/drivers/gpu/drm/bridge/thc63lvd1024.c
+++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
@@ -188,14 +188,9 @@ static int thc63_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, thc63);
thc63->vcc = devm_regulator_get(thc63->dev, "vcc");
- if (IS_ERR(thc63->vcc)) {
- if (PTR_ERR(thc63->vcc) == -EPROBE_DEFER)
- return -EPROBE_DEFER;
-
- dev_err(thc63->dev, "Unable to get \"vcc\" supply: %ld\n",
- PTR_ERR(thc63->vcc));
- return PTR_ERR(thc63->vcc);
- }
+ if (IS_ERR(thc63->vcc))
+ return dev_err_probe(thc63->dev, PTR_ERR(thc63->vcc),
+ "Unable to get \"vcc\" supply\n");
ret = thc63_gpio_init(thc63);
if (ret)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe()
2025-03-27 3:52 [PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe() shao.mingyin
@ 2025-03-27 8:44 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2025-03-27 8:44 UTC (permalink / raw)
To: shao.mingyin
Cc: andrzej.hajda, neil.armstrong, rfoss, jonas, jernej.skrabec,
yang.yang29, xu.xin16, ye.xingchen, linux-kernel, zhang.enpei
Hi Zhang and Shao,
On Thu, Mar 27, 2025 at 11:52:49AM +0800, shao.mingyin@zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> v2:
> - reduce a PTR_ERR call since dev_err_probe() will add
> the error value to the message
> drivers/gpu/drm/bridge/thc63lvd1024.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
> index bba10cf9b4f9..8f3096fa3dd7 100644
> --- a/drivers/gpu/drm/bridge/thc63lvd1024.c
> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
> @@ -188,14 +188,9 @@ static int thc63_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, thc63);
>
> thc63->vcc = devm_regulator_get(thc63->dev, "vcc");
> - if (IS_ERR(thc63->vcc)) {
> - if (PTR_ERR(thc63->vcc) == -EPROBE_DEFER)
> - return -EPROBE_DEFER;
> -
> - dev_err(thc63->dev, "Unable to get \"vcc\" supply: %ld\n",
> - PTR_ERR(thc63->vcc));
> - return PTR_ERR(thc63->vcc);
> - }
> + if (IS_ERR(thc63->vcc))
> + return dev_err_probe(thc63->dev, PTR_ERR(thc63->vcc),
> + "Unable to get \"vcc\" supply\n");
>
> ret = thc63_gpio_init(thc63);
> if (ret)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-27 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-27 3:52 [PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe() shao.mingyin
2025-03-27 8:44 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®