mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: removed unused function
@ 2025-03-28  3:29 James Flowers
  2025-03-28 18:47 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: James Flowers @ 2025-03-28  3:29 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
	christian.koenig, airlied, simona, skhan
  Cc: James Flowers, amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees

Removed unused function mpc401_get_3dlut_fast_load_status.

Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
---
 drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h     | 17 -----------------
 .../drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c  | 11 -----------
 .../drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h  | 14 --------------
 3 files changed, 42 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
index 3a89cc0cffc1..eaef3899da7b 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
@@ -967,23 +967,6 @@ struct mpc_funcs {
 	*/
 
 	void (*update_3dlut_fast_load_select)(struct mpc *mpc, int mpcc_id, int hubp_idx);
-	/**
-	* @get_3dlut_fast_load_status:
-	*
-	* Get 3D LUT fast load status and reference them with done, soft_underflow and hard_underflow pointers.
-	*
-	* Parameters:
-	* - [in/out] mpc - MPC context.
-	* - [in] mpcc_id
-	* - [in/out] done
-	* - [in/out] soft_underflow
-	* - [in/out] hard_underflow
-	*
-	* Return:
-	*
-	* void
-	*/
-	void (*get_3dlut_fast_load_status)(struct mpc *mpc, int mpcc_id, uint32_t *done, uint32_t *soft_underflow, uint32_t *hard_underflow);
 
 	/**
 	* @populate_lut:
diff --git a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
index ad67197557ca..98cf0cbd59ba 100644
--- a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
+++ b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
@@ -47,16 +47,6 @@ void mpc401_update_3dlut_fast_load_select(struct mpc *mpc, int mpcc_id, int hubp
 	REG_SET(MPCC_MCM_3DLUT_FAST_LOAD_SELECT[mpcc_id], 0, MPCC_MCM_3DLUT_FL_SEL, hubp_idx);
 }
 
-void mpc401_get_3dlut_fast_load_status(struct mpc *mpc, int mpcc_id, uint32_t *done, uint32_t *soft_underflow, uint32_t *hard_underflow)
-{
-	struct dcn401_mpc *mpc401 = TO_DCN401_MPC(mpc);
-
-	REG_GET_3(MPCC_MCM_3DLUT_FAST_LOAD_STATUS[mpcc_id],
-			MPCC_MCM_3DLUT_FL_DONE, done,
-			MPCC_MCM_3DLUT_FL_SOFT_UNDERFLOW, soft_underflow,
-			MPCC_MCM_3DLUT_FL_HARD_UNDERFLOW, hard_underflow);
-}
-
 void mpc401_set_movable_cm_location(struct mpc *mpc, enum mpcc_movable_cm_location location, int mpcc_id)
 {
 	struct dcn401_mpc *mpc401 = TO_DCN401_MPC(mpc);
@@ -618,7 +608,6 @@ static const struct mpc_funcs dcn401_mpc_funcs = {
 	.set_bg_color = mpc1_set_bg_color,
 	.set_movable_cm_location = mpc401_set_movable_cm_location,
 	.update_3dlut_fast_load_select = mpc401_update_3dlut_fast_load_select,
-	.get_3dlut_fast_load_status = mpc401_get_3dlut_fast_load_status,
 	.populate_lut = mpc401_populate_lut,
 	.program_lut_read_write_control = mpc401_program_lut_read_write_control,
 	.program_lut_mode = mpc401_program_lut_mode,
diff --git a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
index ce6fbcf14d7a..8e35ebc603a9 100644
--- a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
+++ b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
@@ -241,23 +241,9 @@ void mpc401_update_3dlut_fast_load_select(
 	int mpcc_id,
 	int hubp_idx);
 
-void mpc401_get_3dlut_fast_load_status(
-	struct mpc *mpc,
-	int mpcc_id,
-	uint32_t *done,
-	uint32_t *soft_underflow,
-	uint32_t *hard_underflow);
-
 void mpc401_update_3dlut_fast_load_select(
 	struct mpc *mpc,
 	int mpcc_id,
 	int hubp_idx);
 
-void mpc401_get_3dlut_fast_load_status(
-	struct mpc *mpc,
-	int mpcc_id,
-	uint32_t *done,
-	uint32_t *soft_underflow,
-	uint32_t *hard_underflow);
-
 #endif
-- 
2.49.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/display: removed unused function
  2025-03-28  3:29 [PATCH] drm/amd/display: removed unused function James Flowers
@ 2025-03-28 18:47 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2025-03-28 18:47 UTC (permalink / raw)
  To: James Flowers
  Cc: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
	christian.koenig, airlied, simona, skhan, amd-gfx, dri-devel,
	linux-kernel, linux-kernel-mentees

Applied.  Thanks!

Alex

On Thu, Mar 27, 2025 at 11:37 PM James Flowers
<bold.zone2373@fastmail.com> wrote:
>
> Removed unused function mpc401_get_3dlut_fast_load_status.
>
> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h     | 17 -----------------
>  .../drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c  | 11 -----------
>  .../drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h  | 14 --------------
>  3 files changed, 42 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> index 3a89cc0cffc1..eaef3899da7b 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> @@ -967,23 +967,6 @@ struct mpc_funcs {
>         */
>
>         void (*update_3dlut_fast_load_select)(struct mpc *mpc, int mpcc_id, int hubp_idx);
> -       /**
> -       * @get_3dlut_fast_load_status:
> -       *
> -       * Get 3D LUT fast load status and reference them with done, soft_underflow and hard_underflow pointers.
> -       *
> -       * Parameters:
> -       * - [in/out] mpc - MPC context.
> -       * - [in] mpcc_id
> -       * - [in/out] done
> -       * - [in/out] soft_underflow
> -       * - [in/out] hard_underflow
> -       *
> -       * Return:
> -       *
> -       * void
> -       */
> -       void (*get_3dlut_fast_load_status)(struct mpc *mpc, int mpcc_id, uint32_t *done, uint32_t *soft_underflow, uint32_t *hard_underflow);
>
>         /**
>         * @populate_lut:
> diff --git a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
> index ad67197557ca..98cf0cbd59ba 100644
> --- a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c
> @@ -47,16 +47,6 @@ void mpc401_update_3dlut_fast_load_select(struct mpc *mpc, int mpcc_id, int hubp
>         REG_SET(MPCC_MCM_3DLUT_FAST_LOAD_SELECT[mpcc_id], 0, MPCC_MCM_3DLUT_FL_SEL, hubp_idx);
>  }
>
> -void mpc401_get_3dlut_fast_load_status(struct mpc *mpc, int mpcc_id, uint32_t *done, uint32_t *soft_underflow, uint32_t *hard_underflow)
> -{
> -       struct dcn401_mpc *mpc401 = TO_DCN401_MPC(mpc);
> -
> -       REG_GET_3(MPCC_MCM_3DLUT_FAST_LOAD_STATUS[mpcc_id],
> -                       MPCC_MCM_3DLUT_FL_DONE, done,
> -                       MPCC_MCM_3DLUT_FL_SOFT_UNDERFLOW, soft_underflow,
> -                       MPCC_MCM_3DLUT_FL_HARD_UNDERFLOW, hard_underflow);
> -}
> -
>  void mpc401_set_movable_cm_location(struct mpc *mpc, enum mpcc_movable_cm_location location, int mpcc_id)
>  {
>         struct dcn401_mpc *mpc401 = TO_DCN401_MPC(mpc);
> @@ -618,7 +608,6 @@ static const struct mpc_funcs dcn401_mpc_funcs = {
>         .set_bg_color = mpc1_set_bg_color,
>         .set_movable_cm_location = mpc401_set_movable_cm_location,
>         .update_3dlut_fast_load_select = mpc401_update_3dlut_fast_load_select,
> -       .get_3dlut_fast_load_status = mpc401_get_3dlut_fast_load_status,
>         .populate_lut = mpc401_populate_lut,
>         .program_lut_read_write_control = mpc401_program_lut_read_write_control,
>         .program_lut_mode = mpc401_program_lut_mode,
> diff --git a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
> index ce6fbcf14d7a..8e35ebc603a9 100644
> --- a/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
> +++ b/drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.h
> @@ -241,23 +241,9 @@ void mpc401_update_3dlut_fast_load_select(
>         int mpcc_id,
>         int hubp_idx);
>
> -void mpc401_get_3dlut_fast_load_status(
> -       struct mpc *mpc,
> -       int mpcc_id,
> -       uint32_t *done,
> -       uint32_t *soft_underflow,
> -       uint32_t *hard_underflow);
> -
>  void mpc401_update_3dlut_fast_load_select(
>         struct mpc *mpc,
>         int mpcc_id,
>         int hubp_idx);
>
> -void mpc401_get_3dlut_fast_load_status(
> -       struct mpc *mpc,
> -       int mpcc_id,
> -       uint32_t *done,
> -       uint32_t *soft_underflow,
> -       uint32_t *hard_underflow);
> -
>  #endif
> --
> 2.49.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-28 18:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-28  3:29 [PATCH] drm/amd/display: removed unused function James Flowers
2025-03-28 18:47 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®