mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: nuvoton: Add OHCI node
@ 2025-04-01 23:34 William A. Kennington III
  2025-04-03 14:44 ` Andrew Jeffery
  0 siblings, 1 reply; 3+ messages in thread
From: William A. Kennington III @ 2025-04-01 23:34 UTC (permalink / raw)
  To: Tomer Maimon, Rob Herring
  Cc: devicetree, linux-kernel, openbmc, William A. Kennington III

The EHCI peripheral already exists in the devicetree, but the hardware
also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
works fine for this device already and has been tested on real hardware.

Signed-off-by: William A. Kennington III <william@wkennington.com>
---
V1 -> V2: Fixed nodename from ohci -> usb

 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
index c7880126cc78..5a466e97955a 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
@@ -151,6 +151,13 @@ ehci1: usb@f0806000 {
 			status = "disabled";
 		};
 
+		ohci1: usb@f0807000 {
+			compatible = "generic-ohci";
+			reg = <0xf0807000 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		fiu0: spi@fb000000 {
 			compatible = "nuvoton,npcm750-fiu";
 			#address-cells = <1>;
-- 
2.49.0.472.ge94155a9ec-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: nuvoton: Add OHCI node
  2025-04-01 23:34 [PATCH v2] ARM: dts: nuvoton: Add OHCI node William A. Kennington III
@ 2025-04-03 14:44 ` Andrew Jeffery
  2025-04-16 18:02   ` Tomer Maimon
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2025-04-03 14:44 UTC (permalink / raw)
  To: Tomer Maimon, Rob Herring, William A. Kennington III
  Cc: devicetree, linux-kernel, openbmc

On Tue, 01 Apr 2025 16:34:09 -0700, William A. Kennington III wrote:
> The EHCI peripheral already exists in the devicetree, but the hardware
> also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> works fine for this device already and has been tested on real hardware.
> 
> 

Thanks, I've applied this to be picked up through the BMC tree.

-- 
Andrew Jeffery <andrew@codeconstruct.com.au>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: nuvoton: Add OHCI node
  2025-04-03 14:44 ` Andrew Jeffery
@ 2025-04-16 18:02   ` Tomer Maimon
  0 siblings, 0 replies; 3+ messages in thread
From: Tomer Maimon @ 2025-04-16 18:02 UTC (permalink / raw)
  To: Andrew Jeffery
  Cc: Rob Herring, William A. Kennington III, devicetree, linux-kernel,
	openbmc

William, thanks for the patch.

Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>

On Thu, 3 Apr 2025 at 17:44, Andrew Jeffery <andrew@codeconstruct.com.au> wrote:
>
> On Tue, 01 Apr 2025 16:34:09 -0700, William A. Kennington III wrote:
> > The EHCI peripheral already exists in the devicetree, but the hardware
> > also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> > works fine for this device already and has been tested on real hardware.
> >
> >
>
> Thanks, I've applied this to be picked up through the BMC tree.
>
> --
> Andrew Jeffery <andrew@codeconstruct.com.au>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-16 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-01 23:34 [PATCH v2] ARM: dts: nuvoton: Add OHCI node William A. Kennington III
2025-04-03 14:44 ` Andrew Jeffery
2025-04-16 18:02   ` Tomer Maimon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®