From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v1 11/14] staging: gpib: uapi: Fix CamelCase and IBC Dup
Date: Tue, 8 Apr 2025 22:20:37 +0000 [thread overview]
Message-ID: <20250408222040.186881-12-matchstick@neverthere.org> (raw)
In-Reply-To: <20250408222040.186881-1-matchstick@neverthere.org>
Resolved duplicate entry for IbcSPollBit vs IbcSpollBit.
Correct CamelCase for IBC enums
Adhere to Linux kernel coding style.
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/uapi/gpib_user.h | 63 +++++++++++++--------------
1 file changed, 31 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/gpib/uapi/gpib_user.h b/drivers/staging/gpib/uapi/gpib_user.h
index e02323508245..7f343256c110 100644
--- a/drivers/staging/gpib/uapi/gpib_user.h
+++ b/drivers/staging/gpib/uapi/gpib_user.h
@@ -289,38 +289,37 @@ enum ibask_option {
};
enum ibconfig_option {
- IbcPAD = 0x1,
- IbcSAD = 0x2,
- IbcTMO = 0x3,
- IbcEOT = 0x4,
- IbcPPC = 0x5, /* board only */
- IbcREADDR = 0x6, /* device only */
- IbcAUTOPOLL = 0x7, /* board only */
- IbcCICPROT = 0x8, /* board only */
- IbcIRQ = 0x9, /* board only */
- IbcSC = 0xa, /* board only */
- IbcSRE = 0xb, /* board only */
- IbcEOSrd = 0xc,
- IbcEOSwrt = 0xd,
- IbcEOScmp = 0xe,
- IbcEOSchar = 0xf,
- IbcPP2 = 0x10, /* board only */
- IbcTIMING = 0x11, /* board only */
- IbcDMA = 0x12, /* board only */
- IbcReadAdjust = 0x13,
- IbcWriteAdjust = 0x14,
- IbcEventQueue = 0x15, /* board only */
- IbcSPollBit = 0x16, /* board only */
- IbcSpollBit = 0x16, /* board only */
- IbcSendLLO = 0x17, /* board only */
- IbcSPollTime = 0x18, /* device only */
- IbcPPollTime = 0x19, /* board only */
- IbcEndBitIsNormal = 0x1a,
- IbcUnAddr = 0x1b, /* device only */
- IbcHSCableLength = 0x1f, /* board only */
- IbcIst = 0x20, /* board only */
- IbcRsv = 0x21, /* board only */
- IbcBNA = 0x200 /* device only */
+ IBC_PAD = 0x1,
+ IBC_SAD = 0x2,
+ IBC_TMO = 0x3,
+ IBC_EOT = 0x4,
+ IBC_PPC = 0x5, /* board only */
+ IBC_READDR = 0x6, /* device only */
+ IBC_AUTOPOLL = 0x7, /* board only */
+ IBC_CICPROT = 0x8, /* board only */
+ IBC_IRQ = 0x9, /* board only */
+ IBC_SC = 0xa, /* board only */
+ IBC_SRE = 0xb, /* board only */
+ IBC_EOS_RD = 0xc,
+ IBC_EOS_WRT = 0xd,
+ IBC_EOS_CMP = 0xe,
+ IBC_EOS_CHAR = 0xf,
+ IBC_PP2 = 0x10, /* board only */
+ IBC_TIMING = 0x11, /* board only */
+ IBC_DMA = 0x12, /* board only */
+ IBC_READ_ADJUST = 0x13,
+ IBC_WRITE_ADJUST = 0x14,
+ IBC_EVENT_QUEUE = 0x15, /* board only */
+ IBC_SPOLL_BIT = 0x16, /* board only */
+ IBC_SEND_LLO = 0x17, /* board only */
+ IBC_SPOLL_TIME = 0x18, /* device only */
+ IBC_PPOLL_TIME = 0x19, /* board only */
+ IBC_END_BIT_IS_NORMAL = 0x1a,
+ IBC_UN_ADDR = 0x1b, /* device only */
+ IBC_HS_CABLE_LENGTH = 0x1f, /* board only */
+ IBC_IST = 0x20, /* board only */
+ IBC_RSV = 0x21, /* board only */
+ IBC_BNA = 0x200 /* device only */
};
enum t1_delays {
--
2.43.0
next prev parent reply other threads:[~2025-04-08 22:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 22:20 [PATCH v1 00/14] staging: gpib: Adhering to Linux Code standards Michael Rubin
2025-04-08 22:20 ` [PATCH v1 01/14] staging: gpib: Correct CamelCase for EVENT enums Michael Rubin
2025-04-08 22:20 ` [PATCH v1 02/14] staging: gpib: Correct CamelCase for PPConfig Michael Rubin
2025-04-08 22:20 ` [PATCH v1 03/14] staging: gbip: Alignment should match open parens Michael Rubin
2025-04-08 22:20 ` [PATCH v1 04/14] staging: gpib: common: lines exceeded 100 columns Michael Rubin
2025-04-08 22:20 ` [PATCH v1 05/14] staging: gpib: nec: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 06/14] staging: gpib: tms9914: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 07/14] staging: gpib: ines: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 08/14] staging: gpib: pc2: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 09/14] staging: gpib: tnt4882: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 10/14] staging: gpib: uapi: Fix CamelCase and IBA Dup Michael Rubin
2025-04-08 22:20 ` Michael Rubin [this message]
2025-04-08 22:20 ` [PATCH v1 12/14] staging: gpib: uapi: Fix CamelCase and IB_STB Michael Rubin
2025-04-08 22:20 ` [PATCH v1 13/14] staging: gpib: nec: Fix Improper SPDX comment Michael Rubin
2025-04-08 22:20 ` [PATCH v1 14/14] staging: gpib: tms9914: " Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408222040.186881-12-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®