From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v1 02/14] staging: gpib: Correct CamelCase for PPConfig
Date: Tue, 8 Apr 2025 22:20:28 +0000 [thread overview]
Message-ID: <20250408222040.186881-3-matchstick@neverthere.org> (raw)
In-Reply-To: <20250408222040.186881-1-matchstick@neverthere.org>
Adhere to Linux kernel coding style.
Reported by checkpatch
CHECK: Avoid CamelCase: <PPConfig>
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/tms9914/tms9914.c | 4 ++--
drivers/staging/gpib/uapi/gpib_user.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gpib/tms9914/tms9914.c b/drivers/staging/gpib/tms9914/tms9914.c
index f7ad0b47ebb8..5f167c518c7b 100644
--- a/drivers/staging/gpib/tms9914/tms9914.c
+++ b/drivers/staging/gpib/tms9914/tms9914.c
@@ -736,7 +736,7 @@ irqreturn_t tms9914_interrupt_have_status(struct gpib_board *board, struct tms99
unsigned short command_byte = read_byte(priv, CPTR) & gpib_command_mask;
switch (command_byte) {
- case PPConfig:
+ case PP_CONFIG:
priv->ppoll_configure_state = 1;
/* AUX_PTS generates another UNC interrupt on the next command byte
* if it is in the secondary address group (such as PPE and PPD).
@@ -764,7 +764,7 @@ irqreturn_t tms9914_interrupt_have_status(struct gpib_board *board, struct tms99
break;
}
- if (in_primary_command_group(command_byte) && command_byte != PPConfig)
+ if (in_primary_command_group(command_byte) && command_byte != PP_CONFIG)
priv->ppoll_configure_state = 0;
}
diff --git a/drivers/staging/gpib/uapi/gpib_user.h b/drivers/staging/gpib/uapi/gpib_user.h
index b0c131196a00..ff5a257f9a01 100644
--- a/drivers/staging/gpib/uapi/gpib_user.h
+++ b/drivers/staging/gpib/uapi/gpib_user.h
@@ -130,9 +130,9 @@ enum bus_control_line {
enum cmd_byte {
GTL = 0x1, /* go to local */
SDC = 0x4, /* selected device clear */
- PPConfig = 0x5,
+ PP_CONFIG = 0x5,
#ifndef PPC
- PPC = PPConfig, /* parallel poll configure */
+ PPC = PP_CONFIG, /* parallel poll configure */
#endif
GET = 0x8, /* group execute trigger */
TCT = 0x9, /* take control */
--
2.43.0
next prev parent reply other threads:[~2025-04-08 22:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 22:20 [PATCH v1 00/14] staging: gpib: Adhering to Linux Code standards Michael Rubin
2025-04-08 22:20 ` [PATCH v1 01/14] staging: gpib: Correct CamelCase for EVENT enums Michael Rubin
2025-04-08 22:20 ` Michael Rubin [this message]
2025-04-08 22:20 ` [PATCH v1 03/14] staging: gbip: Alignment should match open parens Michael Rubin
2025-04-08 22:20 ` [PATCH v1 04/14] staging: gpib: common: lines exceeded 100 columns Michael Rubin
2025-04-08 22:20 ` [PATCH v1 05/14] staging: gpib: nec: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 06/14] staging: gpib: tms9914: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 07/14] staging: gpib: ines: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 08/14] staging: gpib: pc2: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 09/14] staging: gpib: tnt4882: " Michael Rubin
2025-04-08 22:20 ` [PATCH v1 10/14] staging: gpib: uapi: Fix CamelCase and IBA Dup Michael Rubin
2025-04-08 22:20 ` [PATCH v1 11/14] staging: gpib: uapi: Fix CamelCase and IBC Dup Michael Rubin
2025-04-08 22:20 ` [PATCH v1 12/14] staging: gpib: uapi: Fix CamelCase and IB_STB Michael Rubin
2025-04-08 22:20 ` [PATCH v1 13/14] staging: gpib: nec: Fix Improper SPDX comment Michael Rubin
2025-04-08 22:20 ` [PATCH v1 14/14] staging: gpib: tms9914: " Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408222040.186881-3-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®