From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v1 10/18] staging: gpib: hp_82335: struct gpib_board_config
Date: Tue, 8 Apr 2025 22:36:50 +0000 [thread overview]
Message-ID: <20250408223659.187109-11-matchstick@neverthere.org> (raw)
In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org>
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/hp_82335/hp82335.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c
index 1a93a456f7bd..32b3aba673d9 100644
--- a/drivers/staging/gpib/hp_82335/hp82335.c
+++ b/drivers/staging/gpib/hp_82335/hp82335.c
@@ -24,7 +24,7 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("GPIB driver for HP 82335 interface cards");
-static int hp82335_attach(struct gpib_board *board, const gpib_board_config_t *config);
+static int hp82335_attach(struct gpib_board *board, const struct gpib_board_config *config);
static void hp82335_detach(struct gpib_board *board);
static irqreturn_t hp82335_interrupt(int irq, void *arg);
@@ -243,7 +243,7 @@ static void hp82335_clear_interrupt(struct hp82335_priv *hp_priv)
writeb(0, tms_priv->mmiobase + HPREG_INTR_CLEAR);
}
-static int hp82335_attach(struct gpib_board *board, const gpib_board_config_t *config)
+static int hp82335_attach(struct gpib_board *board, const struct gpib_board_config *config)
{
struct hp82335_priv *hp_priv;
struct tms9914_priv *tms_priv;
--
2.43.0
next prev parent reply other threads:[~2025-04-08 22:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 22:36 [PATCH v1 00/18] staging: gpib: Removing typedef gpib_board_config_t Michael Rubin
2025-04-08 22:36 ` [PATCH v1 01/18] staing: gpib: struct typing for gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 02/18] staging: gpib: agilent_82350b: gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 03/18] staging: gpib: agilent_82357a: gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 04/18] staging: gpib: cb7210: struct gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 05/18] staging: gpib: cec: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 06/18] staging: gpib: common: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 07/18] staging: gpib: eastwood: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-08 22:36 ` Michael Rubin [this message]
2025-04-08 22:36 ` [PATCH v1 11/18] staging: gpib: hp_82341: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 13/18] staging: gpib: ines: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 18/18] staging: gpib: Removing typedef gpib_board_config Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408223659.187109-11-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®