From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v1 07/18] staging: gpib: eastwood: struct gpib_board_config
Date: Tue, 8 Apr 2025 22:36:47 +0000 [thread overview]
Message-ID: <20250408223659.187109-8-matchstick@neverthere.org> (raw)
In-Reply-To: <20250408223659.187109-1-matchstick@neverthere.org>
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/eastwood/fluke_gpib.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
index 68f888a75edc..e1f8598e4e04 100644
--- a/drivers/staging/gpib/eastwood/fluke_gpib.c
+++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -24,8 +24,10 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("GPIB Driver for Fluke cda devices");
-static int fluke_attach_holdoff_all(struct gpib_board *board, const gpib_board_config_t *config);
-static int fluke_attach_holdoff_end(struct gpib_board *board, const gpib_board_config_t *config);
+static int fluke_attach_holdoff_all(struct gpib_board *board,
+ const struct gpib_board_config *config);
+static int fluke_attach_holdoff_end(struct gpib_board *board,
+ const struct gpib_board_config *config);
static void fluke_detach(struct gpib_board *board);
static int fluke_config_dma(struct gpib_board *board, int output);
static irqreturn_t fluke_gpib_internal_interrupt(struct gpib_board *board);
@@ -943,7 +945,7 @@ static bool gpib_dma_channel_filter(struct dma_chan *chan, void *filter_param)
return chan->chan_id == 0;
}
-static int fluke_attach_impl(struct gpib_board *board, const gpib_board_config_t *config,
+static int fluke_attach_impl(struct gpib_board *board, const struct gpib_board_config *config,
unsigned int handshake_mode)
{
struct fluke_priv *e_priv;
@@ -1049,12 +1051,12 @@ static int fluke_attach_impl(struct gpib_board *board, const gpib_board_config_t
return fluke_init(e_priv, board, handshake_mode);
}
-int fluke_attach_holdoff_all(struct gpib_board *board, const gpib_board_config_t *config)
+int fluke_attach_holdoff_all(struct gpib_board *board, const struct gpib_board_config *config)
{
return fluke_attach_impl(board, config, HR_HLDA);
}
-int fluke_attach_holdoff_end(struct gpib_board *board, const gpib_board_config_t *config)
+int fluke_attach_holdoff_end(struct gpib_board *board, const struct gpib_board_config *config)
{
return fluke_attach_impl(board, config, HR_HLDE);
}
--
2.43.0
next prev parent reply other threads:[~2025-04-08 22:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 22:36 [PATCH v1 00/18] staging: gpib: Removing typedef gpib_board_config_t Michael Rubin
2025-04-08 22:36 ` [PATCH v1 01/18] staing: gpib: struct typing for gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 02/18] staging: gpib: agilent_82350b: gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 03/18] staging: gpib: agilent_82357a: gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 04/18] staging: gpib: cb7210: struct gpib_board_config Michael Rubin
2025-04-08 22:36 ` [PATCH v1 05/18] staging: gpib: cec: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 06/18] staging: gpib: common: " Michael Rubin
2025-04-08 22:36 ` Michael Rubin [this message]
2025-04-08 22:36 ` [PATCH v1 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 10/18] staging: gpib: hp_82335: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 11/18] staging: gpib: hp_82341: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 13/18] staging: gpib: ines: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-08 22:36 ` [PATCH v1 18/18] staging: gpib: Removing typedef gpib_board_config Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408223659.187109-8-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®