mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions
@ 2025-04-09  6:38 Michael Rubin
  2025-04-09  6:38 ` [Patch v1 1/6] staging: gpib: Removing function osInit Michael Rubin
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:38 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

checkpatch reported Camelcase routines in gpib_proto.h. These routines did not
adhere to Linux coding style and also were not defined. This patch series
removes these functions.

* Patch 1 - Patch 6: Removing undefined functions

	Reported by checkpatch.pl as CamelCase where function is never
	defined.

Michael Rubin (6):
  staging: gpib: Removing function osInit
  staging: gpib: Removing function osReset
  staging: gpib: Removing function osSendEOI
  staging: gpib: Removing function ibAPWait
  staging: gpib: Removing function ibaPrsp
  staging: gpib: Removing function ibAPE

 drivers/staging/gpib/include/gpib_proto.h | 7 -------
 1 file changed, 7 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 1/6] staging: gpib: Removing function osInit
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
@ 2025-04-09  6:38 ` Michael Rubin
  2025-04-09  6:39 ` [Patch v1 2/6] staging: gpib: Removing function osReset Michael Rubin
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:38 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osInit>

Removing undefined function.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index 333f5c62da9e..43d655ee324a 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -8,7 +8,6 @@
 int ibopen(struct inode *inode, struct file *filep);
 int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
-int osInit(void);
 void osReset(void);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 2/6] staging: gpib: Removing function osReset
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
  2025-04-09  6:38 ` [Patch v1 1/6] staging: gpib: Removing function osInit Michael Rubin
@ 2025-04-09  6:39 ` Michael Rubin
  2025-04-09  6:39 ` [Patch v1 3/6] staging: gpib: Removing function osSendEOI Michael Rubin
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:39 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osReset>

Removing undefined function.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index 43d655ee324a..0b32404d699c 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -8,7 +8,6 @@
 int ibopen(struct inode *inode, struct file *filep);
 int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
-void osReset(void);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
 void osSendEOI(void);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 3/6] staging: gpib: Removing function osSendEOI
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
  2025-04-09  6:38 ` [Patch v1 1/6] staging: gpib: Removing function osInit Michael Rubin
  2025-04-09  6:39 ` [Patch v1 2/6] staging: gpib: Removing function osReset Michael Rubin
@ 2025-04-09  6:39 ` Michael Rubin
  2025-04-09  6:39 ` [Patch v1 4/6] staging: gpib: Removing function ibAPWait Michael Rubin
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:39 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osSendEOI>

Removing undefined function which appears twice.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index 0b32404d699c..247a73846cfc 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -10,8 +10,6 @@ int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
-void osSendEOI(void);
-void osSendEOI(void);
 void init_gpib_board(struct gpib_board *board);
 static inline unsigned long usec_to_jiffies(unsigned int usec)
 {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 4/6] staging: gpib: Removing function ibAPWait
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
                   ` (2 preceding siblings ...)
  2025-04-09  6:39 ` [Patch v1 3/6] staging: gpib: Removing function osSendEOI Michael Rubin
@ 2025-04-09  6:39 ` Michael Rubin
  2025-04-09  6:39 ` [Patch v1 5/6] staging: gpib: Removing function ibaPrsp Michael Rubin
  2025-04-09  6:39 ` [Patch v1 6/6] staging: gpib: Removing function ibAPE Michael Rubin
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:39 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibaAPWait>

Removing undefined function.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index 247a73846cfc..73d7c7ed25fc 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-int ibAPWait(struct gpib_board *board, int pad);
 int ibAPrsp(struct gpib_board *board, int padsad, char *spb);
 void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 5/6] staging: gpib: Removing function ibaPrsp
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
                   ` (3 preceding siblings ...)
  2025-04-09  6:39 ` [Patch v1 4/6] staging: gpib: Removing function ibAPWait Michael Rubin
@ 2025-04-09  6:39 ` Michael Rubin
  2025-04-09  6:39 ` [Patch v1 6/6] staging: gpib: Removing function ibAPE Michael Rubin
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:39 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibaPrsp>

Removing undefined function.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index 73d7c7ed25fc..fce33f5715fb 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-int ibAPrsp(struct gpib_board *board, int padsad, char *spb);
 void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
 int ibcmd(struct gpib_board *board, uint8_t *buf, size_t length, size_t *bytes_written);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Patch v1 6/6] staging: gpib: Removing function ibAPE
  2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
                   ` (4 preceding siblings ...)
  2025-04-09  6:39 ` [Patch v1 5/6] staging: gpib: Removing function ibaPrsp Michael Rubin
@ 2025-04-09  6:39 ` Michael Rubin
  5 siblings, 0 replies; 7+ messages in thread
From: Michael Rubin @ 2025-04-09  6:39 UTC (permalink / raw)
  To: gregkh, dpenkler; +Cc: linux-staging, linux-kernel, Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibAPE>

Removing undefined function.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/include/gpib_proto.h b/drivers/staging/gpib/include/gpib_proto.h
index fce33f5715fb..4c01c436b9a7 100644
--- a/drivers/staging/gpib/include/gpib_proto.h
+++ b/drivers/staging/gpib/include/gpib_proto.h
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
 int ibcmd(struct gpib_board *board, uint8_t *buf, size_t length, size_t *bytes_written);
 int ibgts(struct gpib_board *board);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-04-09  6:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-09  6:38 [Patch v1 0/6] staging: gpib: Removing undefined CamelCase functions Michael Rubin
2025-04-09  6:38 ` [Patch v1 1/6] staging: gpib: Removing function osInit Michael Rubin
2025-04-09  6:39 ` [Patch v1 2/6] staging: gpib: Removing function osReset Michael Rubin
2025-04-09  6:39 ` [Patch v1 3/6] staging: gpib: Removing function osSendEOI Michael Rubin
2025-04-09  6:39 ` [Patch v1 4/6] staging: gpib: Removing function ibAPWait Michael Rubin
2025-04-09  6:39 ` [Patch v1 5/6] staging: gpib: Removing function ibaPrsp Michael Rubin
2025-04-09  6:39 ` [Patch v1 6/6] staging: gpib: Removing function ibAPE Michael Rubin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®