* [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked()
@ 2025-04-09 19:34 Ashish Kalra
2025-04-14 17:04 ` Tom Lendacky
2025-04-16 7:57 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Ashish Kalra @ 2025-04-09 19:34 UTC (permalink / raw)
To: dan.carpenter, thomas.lendacky, john.allen, herbert, davem
Cc: linux-crypto, linux-kernel
From: Ashish Kalra <ashish.kalra@amd.com>
Fix smatch warning:
drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked()
error: uninitialized symbol 'dfflush_error'.
Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/
Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
---
drivers/crypto/ccp/sev-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 19fb51558a7d..1ccff5e3f4bc 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic)
ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error);
/* SHUTDOWN may require DF_FLUSH */
if (*error == SEV_RET_DFFLUSH_REQUIRED) {
- int dfflush_error;
+ int dfflush_error = SEV_RET_NO_FW_CALL;
ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error);
if (ret) {
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked()
2025-04-09 19:34 [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked() Ashish Kalra
@ 2025-04-14 17:04 ` Tom Lendacky
2025-04-16 7:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2025-04-14 17:04 UTC (permalink / raw)
To: Ashish Kalra, dan.carpenter, john.allen, herbert, davem
Cc: linux-crypto, linux-kernel
On 4/9/25 14:34, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@amd.com>
>
> Fix smatch warning:
> drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked()
> error: uninitialized symbol 'dfflush_error'.
>
> Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/
> Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/sev-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 19fb51558a7d..1ccff5e3f4bc 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic)
> ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error);
> /* SHUTDOWN may require DF_FLUSH */
> if (*error == SEV_RET_DFFLUSH_REQUIRED) {
> - int dfflush_error;
> + int dfflush_error = SEV_RET_NO_FW_CALL;
>
> ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error);
> if (ret) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked()
2025-04-09 19:34 [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked() Ashish Kalra
2025-04-14 17:04 ` Tom Lendacky
@ 2025-04-16 7:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2025-04-16 7:57 UTC (permalink / raw)
To: Ashish Kalra
Cc: dan.carpenter, thomas.lendacky, john.allen, davem, linux-crypto,
linux-kernel
On Wed, Apr 09, 2025 at 07:34:29PM +0000, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@amd.com>
>
> Fix smatch warning:
> drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked()
> error: uninitialized symbol 'dfflush_error'.
>
> Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/
> Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
> ---
> drivers/crypto/ccp/sev-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-16 7:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-09 19:34 [PATCH] crypto: ccp: Fix __sev_snp_shutdown_locked() Ashish Kalra
2025-04-14 17:04 ` Tom Lendacky
2025-04-16 7:57 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®