[PATCH] signal: Update send_signal_locked in relevant comments

[PATCH] signal: Update send_signal_locked in relevant comments

[jiang.kun2]

From: Fan Yu <fan.yu9@zte.com.cn>

The __send_signal has been renamed to __send_signal_locked,
after the following commit:

'commit 157cc18122b4 ("signal: Rename send_signal send_signal_locked")'

But some comments have not been modified along with the
code, so they need to be updated. This will help readers
better understand the code.

Signed-off-by: Fan Yu <fan.yu9@zte.com.cn>
---
 kernel/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 148082db9a55..af5f8bb50491 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2252,7 +2252,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 			sig = 0;
 	}
 	/*
-	 * Send with __send_signal as si_pid and si_uid are in the
+	 * Send with __send_signal_locked as si_pid and si_uid are in the
 	 * parent's namespaces.
 	 */
 	if (valid_signal(sig) && sig)
-- 
2.25.1

Re: [PATCH] signal: Update send_signal_locked in relevant comments

[Oleg Nesterov]

On 04/11, jiang.kun2@zte.com.cn wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2252,7 +2252,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  			sig = 0;
>  	}
>  	/*
> -	 * Send with __send_signal as si_pid and si_uid are in the
> +	 * Send with __send_signal_locked as si_pid and si_uid are in the
>  	 * parent's namespaces.

Thanks, but I think that today this comment looks confusing either way.
It was added by 61e713bdca3678 along with this

	-               __group_send_sig_info(sig, &info, tsk->parent);
	+               __send_signal(sig, &info, tsk->parent, PIDTYPE_TGID, false);

change.

To me this comment looks outdated, perhaps it would be better to simply
remove it?

Or it should be updated to explain that we use __send_signal_locked()
instead of send_signal_locked() because the latter can wrongly change
si_pid/si_uid...

Oleg.