From: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
Subject: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage
Date: Wed, 16 Apr 2025 10:49:51 +0530 [thread overview]
Message-ID: <20250416-remove_assin_resource-v1-1-e92dd361fa0a@quicinc.com> (raw)
Avoid redundant usage of pci_assign_resource for BAR allocation.
This is already taken care by PCIe framework. Invocation of this
API leads to unnecessary relocation of BAR space to a new memory
address.
Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
---
drivers/bus/mhi/host/pci_generic.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..7501abc835c7 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
int err;
- err = pci_assign_resource(pdev, bar_num);
- if (err)
- return err;
-
err = pcim_enable_device(pdev);
if (err) {
dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
---
base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
change-id: 20250416-remove_assin_resource-aa0db88d02eb
Best regards,
--
Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
next reply other threads:[~2025-04-16 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 5:19 Subramanian Ananthanarayanan [this message]
2025-04-16 5:37 ` Krishna Chaitanya Chundru
2025-04-24 5:07 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416-remove_assin_resource-v1-1-e92dd361fa0a@quicinc.com \
--to=quic_skananth@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®