* [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage
@ 2025-04-16 5:19 Subramanian Ananthanarayanan
2025-04-16 5:37 ` Krishna Chaitanya Chundru
2025-04-24 5:07 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Subramanian Ananthanarayanan @ 2025-04-16 5:19 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: mhi, linux-arm-msm, linux-kernel, Subramanian Ananthanarayanan
Avoid redundant usage of pci_assign_resource for BAR allocation.
This is already taken care by PCIe framework. Invocation of this
API leads to unnecessary relocation of BAR space to a new memory
address.
Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
---
drivers/bus/mhi/host/pci_generic.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..7501abc835c7 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
int err;
- err = pci_assign_resource(pdev, bar_num);
- if (err)
- return err;
-
err = pcim_enable_device(pdev);
if (err) {
dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
---
base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
change-id: 20250416-remove_assin_resource-aa0db88d02eb
Best regards,
--
Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage
2025-04-16 5:19 [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage Subramanian Ananthanarayanan
@ 2025-04-16 5:37 ` Krishna Chaitanya Chundru
2025-04-24 5:07 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Krishna Chaitanya Chundru @ 2025-04-16 5:37 UTC (permalink / raw)
To: Subramanian Ananthanarayanan, Manivannan Sadhasivam
Cc: mhi, linux-arm-msm, linux-kernel
On 4/16/2025 10:49 AM, Subramanian Ananthanarayanan wrote:
> Avoid redundant usage of pci_assign_resource for BAR allocation.
> This is already taken care by PCIe framework. Invocation of this
> API leads to unnecessary relocation of BAR space to a new memory
> address.
>
> Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
Reviewed-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> ---
> drivers/bus/mhi/host/pci_generic.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..7501abc835c7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
> struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
> int err;
>
> - err = pci_assign_resource(pdev, bar_num);
> - if (err)
> - return err;
> -
> err = pcim_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
>
> ---
> base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
> change-id: 20250416-remove_assin_resource-aa0db88d02eb
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage
2025-04-16 5:19 [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage Subramanian Ananthanarayanan
2025-04-16 5:37 ` Krishna Chaitanya Chundru
@ 2025-04-24 5:07 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2025-04-24 5:07 UTC (permalink / raw)
To: Subramanian Ananthanarayanan; +Cc: mhi, linux-arm-msm, linux-kernel
On Wed, Apr 16, 2025 at 10:49:51AM +0530, Subramanian Ananthanarayanan wrote:
> Avoid redundant usage of pci_assign_resource for BAR allocation.
> This is already taken care by PCIe framework. Invocation of this
> API leads to unnecessary relocation of BAR space to a new memory
> address.
>
> Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..7501abc835c7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
> struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
> int err;
>
> - err = pci_assign_resource(pdev, bar_num);
> - if (err)
> - return err;
> -
> err = pcim_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
>
> ---
> base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
> change-id: 20250416-remove_assin_resource-aa0db88d02eb
>
> Best regards,
> --
> Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-24 5:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-16 5:19 [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage Subramanian Ananthanarayanan
2025-04-16 5:37 ` Krishna Chaitanya Chundru
2025-04-24 5:07 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®