* [PATCH -next] HID: hid-steam: Remove the unused variable connected
@ 2025-04-16 2:58 Jiapeng Chong
2025-04-24 10:52 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2025-04-16 2:58 UTC (permalink / raw)
To: jikos; +Cc: bentiss, linux-input, linux-kernel, Jiapeng Chong, Abaci Robot
Variable connected is not effectively used, so delete it.
drivers/hid/hid-steam.c:1153:7: warning: variable ‘connected’ set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=20462
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/hid/hid-steam.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c
index dfd9d22ed559..949d307c66a8 100644
--- a/drivers/hid/hid-steam.c
+++ b/drivers/hid/hid-steam.c
@@ -1150,11 +1150,9 @@ static void steam_client_ll_close(struct hid_device *hdev)
struct steam_device *steam = hdev->driver_data;
unsigned long flags;
- bool connected;
spin_lock_irqsave(&steam->lock, flags);
steam->client_opened--;
- connected = steam->connected && !steam->client_opened;
spin_unlock_irqrestore(&steam->lock, flags);
schedule_work(&steam->unregister_work);
--
2.32.0.3.g01195cf9f
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] HID: hid-steam: Remove the unused variable connected
2025-04-16 2:58 [PATCH -next] HID: hid-steam: Remove the unused variable connected Jiapeng Chong
@ 2025-04-24 10:52 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2025-04-24 10:52 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: bentiss, linux-input, linux-kernel, Abaci Robot
On Wed, 16 Apr 2025, Jiapeng Chong wrote:
> Variable connected is not effectively used, so delete it.
>
> drivers/hid/hid-steam.c:1153:7: warning: variable ‘connected’ set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=20462
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-24 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-16 2:58 [PATCH -next] HID: hid-steam: Remove the unused variable connected Jiapeng Chong
2025-04-24 10:52 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®