mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luo Jie <quic_luoj@quicinc.com>
To: Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Julia Lawall <Julia.Lawall@inria.fr>,
	"Nicolas Palix" <nicolas.palix@imag.fr>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <cocci@inria.fr>,
	<linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
	<andrew@lunn.ch>, <quic_kkumarcs@quicinc.com>,
	<quic_linchen@quicinc.com>, <quic_leiwei@quicinc.com>,
	<quic_suruchia@quicinc.com>, <quic_pavir@quicinc.com>,
	Luo Jie <quic_luoj@quicinc.com>
Subject: [PATCH v3 2/6] coccinelle: misc: Add field_modify script
Date: Thu, 17 Apr 2025 18:47:09 +0800	[thread overview]
Message-ID: <20250417-field_modify-v3-2-6f7992aafcb7@quicinc.com> (raw)
In-Reply-To: <20250417-field_modify-v3-0-6f7992aafcb7@quicinc.com>

This script finds and suggests conversions of opencoded field
modify patterns with the wrapper FIELD_MODIFY() API defined in
include/linux/bitfield.h for better readability.

Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
 scripts/coccinelle/misc/field_modify.cocci | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/scripts/coccinelle/misc/field_modify.cocci b/scripts/coccinelle/misc/field_modify.cocci
new file mode 100644
index 000000000000..9022c1b23291
--- /dev/null
+++ b/scripts/coccinelle/misc/field_modify.cocci
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0-only
+///
+/// Replaced below code with the wrapper FIELD_MODIFY(MASK, &reg, val)
+/// - reg &= ~MASK;
+/// - reg |= FIELD_PREP(MASK, val);
+//
+// Confidence: High
+// Author: Luo Jie <quic_luoj@quicinc.com>
+// Copyright (C) 2025 Qualcomm Innovation Center, Inc.
+// URL: https://coccinelle.gitlabpages.inria.fr/website
+// Keywords: FIELD_PREP, FIELD_MODIFY
+// Options: --include-headers
+
+virtual patch
+
+@depends on patch@
+identifier reg, val;
+constant mask;
+symbol FIELD_PREP, FIELD_MODIFY;
+@@
+
+- reg &= ~mask;
+- reg |= FIELD_PREP(mask, val);
++ FIELD_MODIFY(mask, &reg, val);

-- 
2.34.1


  parent reply	other threads:[~2025-04-17 10:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 10:47 [PATCH v3 0/6] Add FIELD_MODIFY() helper Luo Jie
2025-04-17 10:47 ` [PATCH v3 1/6] bitfield: " Luo Jie
2025-04-18 17:11   ` Yury Norov
2025-04-23 13:05     ` Jie Luo
2025-04-17 10:47 ` Luo Jie [this message]
2025-04-23 11:01   ` [cocci] [PATCH v3 2/6] coccinelle: misc: Add field_modify script Markus Elfring
2025-04-23 13:04     ` Jie Luo
2025-04-23 16:35       ` Markus Elfring
2025-05-19 13:44         ` Luo Jie
2025-05-19 15:39           ` Julia Lawall
2025-04-17 10:47 ` [PATCH v3 3/6] arm64: tlb: Convert the opencoded field modify Luo Jie
2025-04-17 18:11   ` Russell King (Oracle)
2025-04-23 13:15     ` Jie Luo
2025-04-24 15:24       ` [cocci] " Keller, Jacob E
2025-04-23 16:54     ` Keller, Jacob E
2025-04-17 10:47 ` [PATCH v3 4/6] arm64: nvhe: " Luo Jie
2025-04-17 11:23   ` Marc Zyngier
2025-04-18 15:14     ` Yury Norov
2025-04-18 15:34       ` Marc Zyngier
2025-04-23 17:48       ` Russell King (Oracle)
2025-04-23 18:27         ` Yury Norov
2025-04-23 19:11           ` Russell King (Oracle)
2025-04-23 19:40             ` Yury Norov
2025-04-17 10:47 ` [PATCH v3 5/6] arm64: kvm: " Luo Jie
2025-04-17 10:47 ` [PATCH v3 6/6] arm64: mm: " Luo Jie
2025-04-17 11:10 ` [PATCH v3 0/6] Add FIELD_MODIFY() helper Marc Zyngier
2025-04-17 17:22   ` Andrew Lunn
2025-04-17 17:45     ` Marc Zyngier
2025-04-18 15:08       ` Yury Norov
2025-04-18 15:35         ` Marc Zyngier
2025-04-18 17:04           ` Yury Norov
2025-04-23 13:19             ` Jie Luo
2025-04-23 17:44         ` Russell King (Oracle)
2025-04-23 18:44           ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417-field_modify-v3-2-6f7992aafcb7@quicinc.com \
    --to=quic_luoj@quicinc.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=andrew@lunn.ch \
    --cc=catalin.marinas@arm.com \
    --cc=cocci@inria.fr \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=maz@kernel.org \
    --cc=nicolas.palix@imag.fr \
    --cc=oliver.upton@linux.dev \
    --cc=quic_kkumarcs@quicinc.com \
    --cc=quic_leiwei@quicinc.com \
    --cc=quic_linchen@quicinc.com \
    --cc=quic_pavir@quicinc.com \
    --cc=quic_suruchia@quicinc.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yury.norov@gmail.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®