mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Vyukov <dvyukov@google.com>,
	Oleg Nesterov <oleg@redhat.com>,
	 Russell King <linux@armlinux.org.uk>,
	Kees Cook <kees@kernel.org>,
	 Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	 Frederic Weisbecker <frederic@kernel.org>,
	 "Paul E. McKenney" <paulmck@kernel.org>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,  Ard Biesheuvel <ardb@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Linus Walleij <linus.walleij@linaro.org>,
	 Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v6 08/31] ARM: entry: Move trace entry to C function
Date: Sun, 20 Apr 2025 00:35:55 +0200	[thread overview]
Message-ID: <20250420-arm-generic-entry-v6-8-95f1fcdfeeb2@linaro.org> (raw)
In-Reply-To: <20250420-arm-generic-entry-v6-0-95f1fcdfeeb2@linaro.org>

This moves over the code entering into tracing into the
C syscall invocation code. As syscall_trace_enter() will
provide the current syscall number from the regs we need
not provide the syscall number to the invocation function
any more.

Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/include/asm/syscall.h | 2 +-
 arch/arm/kernel/entry-common.S | 6 +-----
 arch/arm/kernel/syscall.c      | 5 ++++-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/arch/arm/include/asm/syscall.h b/arch/arm/include/asm/syscall.h
index 1d21f26ecf510ac00a878b4d51a5753ee49475f5..66067d165ba3fbbe0f840a89ae396eb1a311bacc 100644
--- a/arch/arm/include/asm/syscall.h
+++ b/arch/arm/include/asm/syscall.h
@@ -20,7 +20,7 @@
 extern const unsigned long sys_call_table[];
 
 int invoke_syscall(void *table, struct pt_regs *regs, int scno, void *retp);
-int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno, void *retp);
+int invoke_syscall_trace(void *table, struct pt_regs *regs, void *retp);
 
 static inline int syscall_get_nr(struct task_struct *task,
 				 struct pt_regs *regs)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index 77801d039b5f6562b231a6fd4979e318c7e736a6..3cfc6d952ff99be9c4c1be4481ac3039260e3e57 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -292,13 +292,9 @@ ENDPROC(vector_swi)
 	 * context switches, and waiting for our parent to respond.
 	 */
 __sys_trace:
-	add	r0, sp, #S_OFF
-	bl	syscall_trace_enter
-	mov	scno, r0
-	mov	r2, r0				@ scno into r2
 	add	r1, sp, #S_R0 + S_OFF		@ pointer to regs
 	mov	r0, tbl
-	badr	r3, __sys_trace_return
+	badr	r2, __sys_trace_return
 	bl	invoke_syscall_trace
 	cmp	r0, #-1
 	bne	__sys_trace_return
diff --git a/arch/arm/kernel/syscall.c b/arch/arm/kernel/syscall.c
index d637dc74b1c70415933898fbcadbedc71df5f654..377e16c8c53c8e809e3f8b157a889ef115d5c043 100644
--- a/arch/arm/kernel/syscall.c
+++ b/arch/arm/kernel/syscall.c
@@ -21,8 +21,11 @@ __visible int invoke_syscall(void *table, struct pt_regs *regs, int scno, void *
 int invoke_syscall_trace_asm(void *table, struct pt_regs *regs, int scno, void *retp);
 __ADDRESSABLE(invoke_syscall_trace_asm);
 
-__visible int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno, void *retp)
+__visible int invoke_syscall_trace(void *table, struct pt_regs *regs, void *retp)
 {
+	int scno;
+
+	scno = syscall_trace_enter(regs);
 	if (scno == -1)
 		return -1;
 

-- 
2.49.0


  parent reply	other threads:[~2025-04-19 22:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-19 22:35 [PATCH v6 00/31] ARM: Switch to generic entry Linus Walleij
2025-04-19 22:35 ` [PATCH v6 01/31] ARM: Prepare includes for " Linus Walleij
2025-04-19 22:35 ` [PATCH v6 02/31] ARM: ptrace: Split report_syscall() Linus Walleij
2025-04-19 22:35 ` [PATCH v6 03/31] ARM: entry: Skip ret_slow_syscall label Linus Walleij
2025-04-19 22:35 ` [PATCH v6 04/31] ARM: process: Rewrite ret_from_fork i C Linus Walleij
2025-04-19 22:35 ` [PATCH v6 05/31] ARM: process: Remove local restart Linus Walleij
2025-04-19 22:35 ` [PATCH v6 06/31] ARM: entry: Invoke syscalls using C Linus Walleij
2025-04-19 22:35 ` [PATCH v6 07/31] ARM: entry: Rewrite two asm calls in C Linus Walleij
2025-04-19 22:35 ` Linus Walleij [this message]
2025-04-19 22:35 ` [PATCH v6 09/31] ARM: entry: save the syscall sp in thread_info Linus Walleij
2025-04-19 22:35 ` [PATCH v6 10/31] ARM: entry: move all tracing invocation to C Linus Walleij
2025-04-19 22:35 ` [PATCH v6 11/31] ARM: entry: Merge the common and trace entry code Linus Walleij
2025-04-19 22:35 ` [PATCH v6 12/31] ARM: entry: Rename syscall invocation Linus Walleij
2025-04-19 22:36 ` [PATCH v6 13/31] ARM: entry: Create user_mode_enter/exit Linus Walleij
2025-04-19 22:36 ` [PATCH v6 14/31] ARM: entry: Drop trace argument from usr_entry macro Linus Walleij
2025-04-19 22:36 ` [PATCH v6 15/31] ARM: entry: Separate call path for syscall SWI entry Linus Walleij
2025-04-19 22:36 ` [PATCH v6 16/31] ARM: entry: Drop argument to asm_irqentry macros Linus Walleij
2025-04-19 22:36 ` [PATCH v6 17/31] ARM: entry: Implement syscall_exit_to_user_mode() Linus Walleij
2025-04-19 22:36 ` [PATCH v6 18/31] ARM: entry: Drop the superfast ret_fast_syscall Linus Walleij
2025-04-19 22:36 ` [PATCH v6 19/31] ARM: entry: Remove fast and offset register restore Linus Walleij
2025-04-19 22:36 ` [PATCH v6 20/31] ARM: entry: Untangle ret_fast_syscall/to_user Linus Walleij
2025-04-19 22:36 ` [PATCH v6 21/31] ARM: entry: Do not double-call exit functions Linus Walleij
2025-04-19 22:36 ` [PATCH v6 22/31] ARM: entry: Move work processing to C Linus Walleij
2025-04-19 22:36 ` [PATCH v6 23/31] ARM: entry: Stop exiting syscalls like IRQs Linus Walleij
2025-04-19 22:36 ` [PATCH v6 24/31] ARM: entry: Complete syscall and IRQ transition to C Linus Walleij
2025-04-19 22:36 ` [PATCH v6 25/31] ARM: entry: Create irqentry calls from kernel mode Linus Walleij
2025-04-19 22:36 ` [PATCH v6 26/31] ARM: entry: Move in-kernel hardirq tracing to C Linus Walleij
2025-04-19 22:36 ` [PATCH v6 27/31] ARM: irq: Add irqstack helper Linus Walleij
2025-04-19 22:36 ` [PATCH v6 28/31] ARM: entry: Convert to generic entry Linus Walleij
2025-04-19 22:36 ` [PATCH v6 29/31] ARM: entry: Handle dabt, pabt, and und as interrupts Linus Walleij
2025-04-19 22:36 ` [PATCH v6 30/31] ARM: entry: Block IRQs in early IRQ context Linus Walleij
2025-04-19 22:36 ` [PATCH v6 31/31] ARM: entry: Reimplement local restart in C Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250420-arm-generic-entry-v6-8-95f1fcdfeeb2@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dvyukov@google.com \
    --cc=frederic@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®