* [PATCH] arm64: tegra: p2180: Explicitly enable GPU
@ 2025-04-20 22:25 Aaron Kling via B4 Relay
2025-05-08 21:07 ` Thierry Reding
2025-05-08 21:08 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Aaron Kling via B4 Relay @ 2025-04-20 22:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter
Cc: devicetree, linux-tegra, linux-kernel, Aaron Kling
From: Aaron Kling <webgeek1234@gmail.com>
The gpu node originally was explicitly left disabled as it was expected
for the bootloader to enable it. However, this is only done in u-boot.
If u-boot is not in the boot chain, this will never be enabled. Other
Tegra210 devices already explicitly enable the gpu, so make p2180 match.
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
index 9b9d1d15b0c7eafd3895f02db1bc747d7cc8923c..c57bd1356381933a16fc1ee64773961bedae957f 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
@@ -24,6 +24,7 @@ memory@80000000 {
gpu@57000000 {
vdd-supply = <&vdd_gpu>;
+ status = "okay";
};
/* debug port */
---
base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
change-id: 20250420-tx1-gpu-73ac66acbf74
Best regards,
--
Aaron Kling <webgeek1234@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: tegra: p2180: Explicitly enable GPU
2025-04-20 22:25 [PATCH] arm64: tegra: p2180: Explicitly enable GPU Aaron Kling via B4 Relay
@ 2025-05-08 21:07 ` Thierry Reding
2025-05-08 21:08 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2025-05-08 21:07 UTC (permalink / raw)
To: webgeek1234
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Hunter,
devicetree, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Sun, Apr 20, 2025 at 05:25:17PM -0500, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> The gpu node originally was explicitly left disabled as it was expected
> for the bootloader to enable it. However, this is only done in u-boot.
> If u-boot is not in the boot chain, this will never be enabled. Other
> Tegra210 devices already explicitly enable the gpu, so make p2180 match.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
> 1 file changed, 1 insertion(+)
This is risky, because the U-Boot code was explicitly added to avoid an
issue during boot. It's probably okay to do this nowadays because all of
the boot stacks deal with this properly and as evidenced by Jetson Nano,
things still seem to work.
It may mean that users of very old L4T releases may have to update, but
they probably should do so anyway, so let's give this a go.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: tegra: p2180: Explicitly enable GPU
2025-04-20 22:25 [PATCH] arm64: tegra: p2180: Explicitly enable GPU Aaron Kling via B4 Relay
2025-05-08 21:07 ` Thierry Reding
@ 2025-05-08 21:08 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2025-05-08 21:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Aaron Kling
Cc: devicetree, linux-tegra, linux-kernel
From: Thierry Reding <treding@nvidia.com>
On Sun, 20 Apr 2025 17:25:17 -0500, Aaron Kling wrote:
> The gpu node originally was explicitly left disabled as it was expected
> for the bootloader to enable it. However, this is only done in u-boot.
> If u-boot is not in the boot chain, this will never be enabled. Other
> Tegra210 devices already explicitly enable the gpu, so make p2180 match.
>
>
Applied, thanks!
[1/1] arm64: tegra: p2180: Explicitly enable GPU
commit: d1b72547610497ea4d0917214986cffb752a8710
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-08 21:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-20 22:25 [PATCH] arm64: tegra: p2180: Explicitly enable GPU Aaron Kling via B4 Relay
2025-05-08 21:07 ` Thierry Reding
2025-05-08 21:08 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®